Seating: Vegetarian and Vegan together show both, not nobody - #93
Merged
Merged
Conversation
Seating's guest filter chips were all ANDed. A guest has one diet and one side, so ticking Vegetarian and Vegan always showed an empty list, and ticking both partners' chips showed only the guests on both sides. Chips in one category (diet, side) now widen the list, and chips in different categories still narrow it: Vegan + Alex's is Alex's vegans. Closes #65 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhFp1PtVBwgmxST9ZrRTEs
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
What a user would notice
Cause
matchesFiltersinutils/guestFilters.tsANDed every active chip. A guest has one diet and one side, so two chips from the same category could never both match.Fix
Each chip has a category (seat, side, diet, notes). The list shows guests who match any chip in each category, and every category that has a chip ticked. Unknown chip keys are still ignored, as before.
Checks
utils/guestFilters.test.jsfor both combinations, and for narrowing across categories. All three failed onmainand pass now. The existing Unassigned test is unchanged and passes.guests.spec.ts, a single chip) passes.Touches the same file as the family-search PR; they merge cleanly in either order (checked locally).
🤖 Generated with Claude Code
https://claude.ai/code/session_01VhFp1PtVBwgmxST9ZrRTEs
Generated by Claude Code