Repository navigation
Beta 1.3.1: fix classic shortcuts for Japanese paths - #3
Merged
Merged
Conversation
Classic .lnk shortcuts were written through WScript.Shell, which converts strings to the ANSI code page. Games with Japanese characters in the exe, folder or name got "???" paths, so the icon pointed nowhere and Explorer showed VNAR's icon. Write them with IShellLinkW instead, and read them back the same way in VNAR.ShellTests, with a Japanese name/folder/icon case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xg3foxU67kLRiYzCqfGnUh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix on top of Beta 1.3 (no other changes).
Classic
.lnkshortcuts were written throughWScript.Shell, which converts strings to the ANSI code page. For games whose executable, folder or name has Japanese characters, the icon path became???.exe, so Explorer showed VNAR's icon instead of the game's and the shortcut looked like a modern one.IShellLinkW(Unicode).VNAR.ShellTestsreads shortcuts back throughIShellLinkWand adds a case with a Japanese name, folder and icon path.1.0.0-beta.1.3.1; CHANGELOG and README links updated.Generated by Claude Code