Skip to content

Apply Rector fix#13

Merged
overclokk merged 11 commits into
masterfrom
rector-fix
May 19, 2026
Merged

Apply Rector fix#13
overclokk merged 11 commits into
masterfrom
rector-fix

Conversation

@overclokk

Copy link
Copy Markdown
Contributor

Description

This pull request introduces a series of refactors aimed at improving the consistency, clarity, and maintainability of the codebase. Key changes include:

  • Docker Setup: Improved host user and group mappings, enhanced permissions management, and aligned code execution with the www-data user.
  • Class Aliasing: Updated logic to ensure aliases are conditionally created only when the target class does not already exist.
  • Rector Configuration: Simplified rules, enabled unused import removal, and enhanced coding styles.
  • Imports and Classes: Simplified imports and class declarations, removed unused imports, and replaced fully qualified names with use statements for better clarity.
  • Test Improvements: Updated test assertions for stricter type checks, declared all test classes as final for consistency, and removed unused test methods.
  • Keyword Usage: Added readonly keyword where applicable and enforced consistency by marking relevant classes as final and readonly.
  • Dependencies and Config: Updated phpstan and rector dependencies, cleaned up Rector configurations, and streamlined the codebase by removing redundant code.
  • Unit Test Bootstrap: Introduced a bootstrap to facilitate testing of final classes.

Checklist

  • Tests have been added/updated where necessary.
  • Documentation has been updated (if applicable).
  • Code adheres to the coding standards.
  • Changes have been tested and verified.

overclokk added 11 commits May 18, 2026 21:40
…t constructor injection, improve type declarations, and apply minor code cleanups
…, add bootstrap for unit tests to make final classes testable, and update composer dev dependencies
…adonly` from constructor properties for consistency
…cision checks, and remove unused test methods
…nd test classes, replacing fully qualified names with use statements for clarity and consistency
…enable unused import removal, and apply coding style improvements
…ted if the target class does not already exist
… improve permissions management, and align code execution with `www-data` user
@overclokk overclokk merged commit 8649ed2 into master May 19, 2026
6 checks passed
@overclokk overclokk deleted the rector-fix branch May 19, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant