Adding Ionic support#17
Open
harsszegi wants to merge 4 commits into
Open
Conversation
added 4 commits
August 12, 2020 07:09
Ionic uses different event binding compared to Angular (focus vs ionFocus, blur vs ionBlur), so the keyboard directive had to be updated so that it still works with both input/textarea and ion-input/ion-textarea
this.input.nativeElement can't be directly used with Ionic as obviously that would resolve to an IonInput (or IonTextArea respectively). Ionic provides a getInputElement() function but that returns a Promise, which would mean to refactor internally quite a lot of code in keyboard-key. Instead directly the firstChild attribute is used, which is exactly the same thing.
In case a selection is in place and you wish to replace that with a character and there is maximum limit set and the input field is already filled completely to the maximum, you are unable to replace the selected content.
Entering text into <input> doesn't work even if maxLength is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds support to Ionic.
As Ionic uses different events for its input components (ionBlur, ionFocus, etc.) and obviously because of the "middle man issue" (e.g. Ionic sets between the keyboard component and the final HTMLInputElement) the following changes had to be done:
a.) Add support for Ionic's events in MatKeyboardDirective
b.) Generalize HTMLInputElement handling via getting the appropriate attribute from the element using matKeyboard
(e.g. use either this.input.nativeElement ('normal case') or this.input.nativeElement.firstChild ('ionic case')