Skip to content

[IP-696]: fix: require PHP ^8.4 to match CI and mb_str_functions usage #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielsdrost7 merged 1 commit into from
Jul 31, 2026
+3 −3
Merged

[IP-696]: fix: require PHP ^8.4 to match CI and mb_str_functions usage #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# InvoicePlane v2

[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
[![PHP Version](https://img.shields.io/badge/PHP-8.3%2B-blue.svg)](https://php.net)
[![PHP Version](https://img.shields.io/badge/PHP-8.4%2B-blue.svg)](https://php.net)

@coderabbitai coderabbitai Bot Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== files =="
git ls-files | rg '(^|/)(README\.md|composer\.(json|lock))$' || true

echo "== composer.json =="
if [ -f composer.json ]; then
  cat -n composer.json | sed -n '1,80p'
fi

echo "== composer.lock platform constraints (if present) =="
if [ -f composer.lock ]; then
  python3 - <<'PY'
import json
p='composer.lock'
with open(p) as f:
    data=json.load(f)
print('platform:', data.get('platform','not set'))
print('platform-dev:', data.get('platform-dev','not set'))
print('has platform overrides:', data.get('platform-overrides','not set'))
PY
fi

echo "== README relevant lines =="
if [ -f README.md ]; then
  cat -n README.md | sed -n '1,60p'
fi

echo "== search PHP version mentions =="
rg -n "PHP|php|8\.4|8\.5|9\.0|composer\.json|require|platform" -S . --glob 'README.md' --glob 'composer.json' --glob 'composer.lock' || true

Repository: InvoicePlane/InvoicePlane-v2

Length of output: 50387

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== composer.json =="
if [ -f composer.json ]; then
  python3 - <<'PY'
import json
with open('composer.json') as f:
    data=json.load(f)
for key in ['require','require-dev','suggest','config','platform','scripts']:
    if key in data:
        print(json.dumps({key:data[key]}, indent=2, sort_keys=True))
PY
fi

echo "== composer.lock platform fields =="
if [ -f composer.lock ]; then
  python3 - <<'PY'
import json
with open('composer.lock') as f:
    data=json.load(f)
print({
    "platform": data.get("platform"),
    "platform-dev": data.get("platform-dev"),
    "platform-overrides": data.get("platform-overrides")
})
PY
fi

echo "== exact composer and package manifests for PHP version constraints =="
rg -n '"php"|"RequirePHP"|"requires_ph[pa]p|requiresPHP|RequirePhp|php [=<>]|PHP [=<>]' -S composer.json README.md composer.lock || true

echo "== README PHP line context =="
if [ -f README.md ]; then
  nl -ba README.md | sed -n '4p;45,50p'
fi

Repository: InvoicePlane/InvoicePlane-v2

Length of output: 12442

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== inspect relevant repository files =="
git ls-files | rg '(^|/)(README\.md|composer\.(json|lock))$' || true
printf '\n'

if [ -f composer.json ]; then
  printf '%s\n' '== composer.json (first 120 lines) =='
  cat -n composer.json | sed -n '1,120p'
  printf '\n'
fi

if [ -f composer.lock ]; then
  printf '%s\n' '== composer.lock platform fields =='
  python3 - <<'PY'
import json
with open('composer.lock') as f:
    data=json.load(f)
print({
    "platform": data.get("platform"),
    "platform-dev": data.get("platform-dev"),
    "platform-overrides": data.get("platform-overrides")
})
PY
  printf '\n'
fi

if [ -f README.md ]; then
  printf '%s\n' '== README.md (first 80 lines) =='
  cat -n README.md | sed -n '1,80p'
  printf '\n'
fi

echo "== focused PHP/require search =="
rg -n '"php"|"php[ =<>]|PHP 8\.4|PHP 9\.0|Requires PHP|require:"|platform:"|platform-dev:"' -S composer.json README.md composer.lock || true

Repository: InvoicePlane/InvoicePlane-v2

Length of output: 17914

Align README with the Composer PHP range.

^8.4 on composer.json:20 only permits PHP >=8.4.0 <9.0.0. Change README.md:4 to PHP 8.4–8.x or update the Composer constraint to support later PHP versions.

Also applies to: 47-47

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 4, Align the README PHP badge with the Composer constraint
by changing the badge text near the PHP Version link to indicate PHP 8.4–8.x,
preserving the existing badge URL and link.

[![Laravel Version](https://img.shields.io/badge/Laravel-13%2B-red.svg)](https://laravel.com)
[![Filament Version](https://img.shields.io/badge/Filament-5.x-orange.svg)](https://filamentphp.com)

Expand Down Expand Up @@ -44,7 +44,7 @@

## 📦 Requirements

- **PHP** 8.3 or higher
- **PHP** 8.4 or higher
- **Composer** 2.x
- **Node.js** 20+ and Yarn
- **Database** MariaDB 10.11+ (recommended), MySQL 8.0+, or SQLite (dev only)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"minimum-stability": "dev",
"prefer-stable": true,
"require": {
"php": "^8.3",
"php": "^8.4",
"awcodes/mason": "^3.1",
"doctrine/dbal": ">=4.4",
"dompdf/dompdf": "^3.1",
Expand Down
Loading