[IP-394]: apply client and template CC addresses to invoice emails - #695
Merged
Conversation
KhawarMehfooz
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…Plane#696) composer.json declared PHP ^8.3, but pint.json enables mb_str_functions (mb_trim/mb_ltrim/mb_rtrim, added in PHP 8.4) and every CI workflow pins php-version 8.4. Installing on real PHP 8.3.x would fatal on any of the existing mb_trim() call sites. Bumps the composer constraint and README requirements to 8.4 to match what the project actually needs.
Collaborator
|
@KhawarMehfooz thanks man! Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Checklist
Description
InvoiceService::sendInvoiceEmail()now CC's the customer's stored CC email addresses (captured viaRelation::email_cc/RelationService::syncCcEmails()) and the invoice email template'scccolumn when queuing an invoice email. Addresses from both sources are merged, validated, and de-duplicated before being passed toMail::cc().Related Issue(s)
Fixes #394
Motivation and Context
The capture path for per-client CC emails was already built (client edit form →
INVOICE_CCcommunications), but the send path never read it —InvoiceService::sendInvoiceEmail()only calledMail::to($recipient), so invoices were silently never CC'd despite users configuring the setting. This closes that gap by applying both the client's CC list and the email template'sccfield to every outgoing invoice email.Issue Type (Check one or more)
Screenshots (If Applicable)
N/A
Summary by CodeRabbit
New Features
Bug Fixes