[IP-235]: company settings

.claude/skills/test-gaps/SKILL.md

@@ -0,0 +1,63 @@
+---
+name: test-gaps
+description: Flags security- or correctness-critical logic (auth checks, guards, validation) added or changed without a test proving both its allow and its deny path
+---
+
+# Purpose
+
+Catches the specific failure mode where a real behavior change ships with no test proving it
+works: code added to prevent something bad, with nothing that proves the bad thing is actually
+prevented. Triggered by this incident: an `abort_unless`/authorization guard was added to
+`MyCompanies::switch` with zero test coverage — it could have been silently deleted or inverted
+in a later change and nothing would fail.
+
+This is narrower than `security-review` (which finds *missing* guards in code) and unrelated to
+`test-honesty` (which is about schema/factory/seeder alignment). This skill assumes the guard
+already exists and asks: is there a test that would fail if the guard were removed?
+
+---
+
+# 1. Trigger Conditions
+
+Apply this check whenever a diff adds or modifies any of:
+
+- an authorization/ownership check (`abort_if`/`abort_unless`, `Gate::`, `->can()`, a Policy
+  method, a custom `assertBelongsTo*`/`assertOwns*`-style guard)
+- input validation added specifically to reject a class of bad input (not just Filament's
+  built-in `->required()`/`->rule()` form validation, which already has its own test convention)
+- a permission/role check gating an action, route, or Livewire method
+
+---
+
+# 2. Coverage Rule
+
+Every guard covered by Rule 1 needs **two** tests, not one:
+
+- **Allow path**: the legitimate case still succeeds through the guard.
+- **Deny path**: the guard actually blocks the illegitimate case — asserts the specific
+  exception/response the guard produces, not just "doesn't crash."
+
+A guard with only an allow-path test (or no test) is a gap: nothing would catch the guard being
+weakened, removed, or silently made a no-op in a later refactor.
+
+---
+
+# 3. Test Placement Rule
+
+If the guard lives inline inside a Filament/Livewire action closure, page method, or controller,
+and testing it directly would require going through framework machinery that doesn't reliably
+reach the unauthorized case (e.g. a table's own query already scopes out records the user
+couldn't select in the first place, so a Feature test via `callTableAction()` never actually
+exercises the deny path), that's a signal the check belongs in an extracted, directly-testable
+method — a service method, a Policy, a dedicated class — not a reason to skip the deny-path test.
+
+---
+
+# 4. What This Skill Does NOT Do
+
+- Does not invent new authorization requirements — only checks that guards which already exist
+  in the diff are proven by tests.
+- Does not replace `security-review`'s job of spotting where a guard is *missing* entirely.
+- Does not apply to routine Filament form validation (`->required()`, `->rule()`, etc.) — that
+  has its own established test conventions in this codebase and isn't the failure mode this
+  skill targets.

.github/DOCKER.md

@@ -44,21 +44,38 @@ Visit: http://localhost:8080 (override the port with `APP_PORT` in `.env`).
 
 Both PHP images ship the full extension set the app needs: `intl`, `gd`,
 `pdo_mysql`, `bcmath`, `zip`, `exif`, `soap`, `redis`. The CLI image also has
-Composer, a 1G memory limit for the test suite, and bundled `pdo_sqlite`
-(the suite runs on an in-memory sqlite database — no db service needed for
-tests).
+Composer and a 1G memory limit for the test suite.
 
 ---
 
 ## Running the test suite
 
 ```bash
-docker compose run --rm cli vendor/bin/phpunit --exclude-group failing,troubleshooting
+docker compose run --rm cli php artisan test --exclude-group failing,troubleshooting
 ```
 
-`APP_ENV=testing` is the `cli` service default, so `.env.testing`
-(sqlite `:memory:`) is picked up automatically. See `RUNNING_TESTS.md` for
-filters, groups, and suites.
+Use `php artisan test`, not `vendor/bin/phpunit` directly — the two have been observed to behave
+differently for this app: a raw `vendor/bin/phpunit` run silently drops some submitted field
+values in Livewire form tests. `artisan test` is the proven-reliable path and is what CI uses, so
+standardize on it.
+
+**Known issue (see [#689](https://github.com/InvoicePlane/InvoicePlane-v2/issues/689)):** a
+freshly-`docker compose build`'t `cli` image has, at least once, reproduced this same
+field-dropping bug at scale (100+ false failures) even under `artisan test`, for reasons not yet
+isolated — despite extension/ini parity with a known-good image. Before trusting a full local run
+from a rebuilt `cli` image, sanity-check it against a small, known test first, e.g.:
+```bash
+docker compose run --rm cli php artisan test --filter=ContactsTest
+```
+All 11 assertions should pass. If any fail with "field is required" errors on data you know you
+supplied, don't trust the rest of that run — see the linked issue.
+
+`APP_ENV=testing` is the `cli` service default, and it always connects to
+the compose stack's real `db` service (MariaDB) for tests — the `cli`
+service injects `DB_CONNECTION=mysql`/`DB_HOST=db`/etc. itself, so nothing
+in `.env.testing` needs editing. This intentionally does not fall back to
+SQLite: SQLite's lenient identifier quoting has masked real bugs before that
+only surfaced against MariaDB in CI.
 
 ### File ownership on Linux
 

.github/workflows/phpunit.yml

@@ -51,4 +51,9 @@ jobs:
         run: php artisan migrate --force --env=testing
 
       - name: Run PHPUnit
+        # No --exclude-group flag here on purpose: passing it explicitly on the
+        # CLI was found to override (not add to) phpunit.xml's own <groups>
+        # <exclude> config, causing failing/flaky/troubleshooting-tagged tests
+        # to run anyway — confirmed by testing both ways. phpunit.xml's own
+        # config already excludes them; rely on that instead.
         run: php artisan test --env=testing

AGENTS.md

@@ -10,10 +10,9 @@ Laravel 11 + Filament v4 + Livewire v3 invoicing app. Modular architecture via `
 composer install
 cp .env.example .env && php artisan key:generate
 php artisan migrate && php artisan db:seed
-# Tests (no MySQL locally? use SQLite)
+# Tests run against real MariaDB — no SQLite fallback (parity with CI)
 cp .env.testing.example .env.testing
-# set DB_CONNECTION=sqlite, DB_DATABASE=:memory: in .env.testing
-php artisan test
+docker compose run --rm cli php artisan test --exclude-group failing,troubleshooting
 ```
 
 ---

CLAUDE.md

@@ -195,11 +195,21 @@ User::factory()->create(['is_active' => true, 'email_verified_at' => now()])
 
 ### DB for tests
 
-Tests need a DB. Production CI uses MariaDB 11. For local dev without MySQL, set in `.env.testing`:
+Tests need a real MariaDB DB — matching CI (MariaDB 11) — not SQLite. SQLite's lenient identifier
+quoting has silently masked real bugs before (e.g. `->latest()` defaulting to a nonexistent
+`created_at` column on `$timestamps = false` models passed locally, failed on CI). Run via the
+`cli` compose service, which points at the stack's `db` service automatically:
 ```
-DB_CONNECTION=sqlite
-DB_DATABASE=:memory:
+docker compose run --rm cli php artisan test --exclude-group failing,troubleshooting
 ```
+No `.env.testing` edits needed — the `cli` service injects `DB_CONNECTION=mysql`/`DB_HOST=db` etc.
+itself. Use `php artisan test`, not `vendor/bin/phpunit` directly — the two have been observed to
+behave differently for this app's Livewire form tests; `artisan test` is the reliable one.
+**Known issue:** a freshly-rebuilt `cli` image has reproduced false Livewire-form failures at
+scale even under `artisan test`, for reasons not yet isolated — see
+[#689](https://github.com/InvoicePlane/InvoicePlane-v2/issues/689) and sanity-check with
+`--filter=ContactsTest` (should be 11/11 passing) before trusting a full run from a rebuilt image.
+See `.github/DOCKER.md`.
 
 ### AAA phase comment style
 

Makefile

@@ -2,6 +2,13 @@
 ## InvoicePlane v2 — Development Makefile
 ## ──────────────────────────────────────────────────────────────────────────────
 ##
+## NOTE: `vendor/bin/phpunit` (used by the targets below) and `php artisan
+## test` (make artisan-test) have been observed to behave differently for
+## this app — a raw phpunit run has silently dropped submitted field values
+## in Livewire form tests in some environments. If a target below reports a
+## failure that `make artisan-filter FILTER="..."` doesn't reproduce, prefer
+## the artisan-test variant; it matches what CI runs.
+##
 ## QUICK START
 ##   make test          Run the full PHPUnit suite (all tests)
 ##   make smoke         Run only @group smoke tests (fast sanity check)

Modules/Core/Filament/Company/Pages/CompanySettings.php

@@ -4,6 +4,7 @@
 
 use BackedEnum;
 use Filament\Actions\Action;
+use Filament\Forms\Components\CheckboxList;
 use Filament\Forms\Components\FileUpload;
 use Filament\Forms\Components\Select;
 use Filament\Forms\Components\Textarea;
@@ -18,9 +19,11 @@
 use Filament\Schemas\Components\Tabs;
 use Filament\Schemas\Components\Tabs\Tab;
 use Modules\Core\Enums\Permission;
+use Modules\Core\Models\EmailTemplate;
 use Modules\Core\Models\Numbering;
 use Modules\Core\Models\Setting;
 use Modules\Core\Models\TaxRate;
+use Modules\Payments\Enums\PaymentMethod;
 use RuntimeException;
 
 /**
@@ -88,6 +91,14 @@ public function mount(): void
         $defaults[Setting::KEY_QUOTE_PDF_MARK_SENT] ??= '0';
         $defaults[Setting::KEY_SMTP_VERIFY_CERTS] ??= '1';
 
+        // Multi-value settings are stored JSON-encoded (Setting::saveForCompany
+        // json_encode()s non-scalars) — decode back into an array for the
+        // CheckboxList, defaulting to "all enabled" for a brand new company.
+        $enabledPaymentMethods = $defaults[Setting::KEY_ENABLED_PAYMENT_METHODS] ?? null;
+        $defaults[Setting::KEY_ENABLED_PAYMENT_METHODS] = filled($enabledPaymentMethods)
+            ? json_decode($enabledPaymentMethods, true)
+            : PaymentMethod::values();
+
         $this->form->fill($defaults);
     }
 
@@ -104,13 +115,19 @@ public function save(): void
             }
 
             // Normalize: Toggles return bool, Selects can return null, etc.
-            if (is_bool($value)) {
+            // Arrays (e.g. CheckboxList) are passed through as-is —
+            // Setting::saveForCompany() JSON-encodes non-scalars itself.
+            if (is_array($value)) {
+                // no-op, saveForCompany() handles it
+            } elseif (is_bool($value)) {
                 $value = $value ? '1' : '0';
             } elseif ($value === null) {
                 $value = '';
+            } else {
+                $value = (string) $value;
             }
 
-            Setting::saveForCompany($companyId, $key, (string) $value);
+            Setting::saveForCompany($companyId, $key, $value);
         }
 
         $this->dispatch('saved');
@@ -251,17 +268,23 @@ protected function getFormSchema(): array
 
                                 Select::make(Setting::KEY_INVOICE_EMAIL_TEMPLATE)
                                     ->label(trans('ip.default_email_template'))
-                                    ->options([])
+                                    ->options(fn () => EmailTemplate::query()
+                                        ->where('company_id', $this->getCompanyId())
+                                        ->pluck('title', 'id'))
                                     ->placeholder(trans('ip.none')),
 
                                 Select::make(Setting::KEY_INVOICE_PAID_EMAIL_TEMPLATE)
                                     ->label(trans('ip.email_template_paid'))
-                                    ->options([])
+                                    ->options(fn () => EmailTemplate::query()
+                                        ->where('company_id', $this->getCompanyId())
+                                        ->pluck('title', 'id'))
                                     ->placeholder(trans('ip.none')),
 
                                 Select::make(Setting::KEY_INVOICE_OVERDUE_EMAIL_TEMPLATE)
                                     ->label(trans('ip.email_template_overdue'))
-                                    ->options([])
+                                    ->options(fn () => EmailTemplate::query()
+                                        ->where('company_id', $this->getCompanyId())
+                                        ->pluck('title', 'id'))
                                     ->placeholder(trans('ip.none')),
 
                                 Textarea::make(Setting::KEY_INVOICE_PDF_FOOTER)
@@ -326,7 +349,9 @@ protected function getFormSchema(): array
 
                                 Select::make(Setting::KEY_QUOTE_EMAIL_TEMPLATE)
                                     ->label(trans('ip.quote_default_email_template'))
-                                    ->options([])
+                                    ->options(fn () => EmailTemplate::query()
+                                        ->where('company_id', $this->getCompanyId())
+                                        ->pluck('title', 'id'))
                                     ->placeholder(trans('ip.none')),
 
                                 Textarea::make(Setting::KEY_QUOTE_PDF_FOOTER)
@@ -355,6 +380,18 @@ protected function getFormSchema(): array
                             ]),
                         ]),
 
+                    Tab::make('Payments')
+                        ->schema([
+                            Section::make(trans('ip.payments'))->columns(1)->schema([
+                                CheckboxList::make(Setting::KEY_ENABLED_PAYMENT_METHODS)
+                                    ->label(trans('ip.enabled_payment_methods'))
+                                    ->options(collect(PaymentMethod::cases())
+                                        ->mapWithKeys(fn (PaymentMethod $method) => [$method->value => $method->label()])
+                                        ->toArray())
+                                    ->columns(2),
+                            ]),
+                        ]),
+
                     Tab::make('Email')
                         ->schema([
                             Section::make(trans('ip.email'))->columns(2)->schema([
@@ -454,6 +491,7 @@ private function allKeys(): array
             Setting::KEY_SMTP_PASSWORD,
             Setting::KEY_SMTP_SECURITY,
             Setting::KEY_SMTP_VERIFY_CERTS,
+            Setting::KEY_ENABLED_PAYMENT_METHODS,
         ];
     }