[IP-44]: batch of trivial fixes (#342, #606, #402, #44)

.claude/skills/test-gaps/SKILL.md

@@ -0,0 +1,63 @@
+---
+name: test-gaps
+description: Flags security- or correctness-critical logic (auth checks, guards, validation) added or changed without a test proving both its allow and its deny path
+---
+
+# Purpose
+
+Catches the specific failure mode where a real behavior change ships with no test proving it
+works: code added to prevent something bad, with nothing that proves the bad thing is actually
+prevented. Triggered by this incident: an `abort_unless`/authorization guard was added to
+`MyCompanies::switch` with zero test coverage — it could have been silently deleted or inverted
+in a later change and nothing would fail.
+
+This is narrower than `security-review` (which finds *missing* guards in code) and unrelated to
+`test-honesty` (which is about schema/factory/seeder alignment). This skill assumes the guard
+already exists and asks: is there a test that would fail if the guard were removed?
+
+---
+
+# 1. Trigger Conditions
+
+Apply this check whenever a diff adds or modifies any of:
+
+- an authorization/ownership check (`abort_if`/`abort_unless`, `Gate::`, `->can()`, a Policy
+  method, a custom `assertBelongsTo*`/`assertOwns*`-style guard)
+- input validation added specifically to reject a class of bad input (not just Filament's
+  built-in `->required()`/`->rule()` form validation, which already has its own test convention)
+- a permission/role check gating an action, route, or Livewire method
+
+---
+
+# 2. Coverage Rule
+
+Every guard covered by Rule 1 needs **two** tests, not one:
+
+- **Allow path**: the legitimate case still succeeds through the guard.
+- **Deny path**: the guard actually blocks the illegitimate case — asserts the specific
+  exception/response the guard produces, not just "doesn't crash."
+
+A guard with only an allow-path test (or no test) is a gap: nothing would catch the guard being
+weakened, removed, or silently made a no-op in a later refactor.
+
+---
+
+# 3. Test Placement Rule
+
+If the guard lives inline inside a Filament/Livewire action closure, page method, or controller,
+and testing it directly would require going through framework machinery that doesn't reliably
+reach the unauthorized case (e.g. a table's own query already scopes out records the user
+couldn't select in the first place, so a Feature test via `callTableAction()` never actually
+exercises the deny path), that's a signal the check belongs in an extracted, directly-testable
+method — a service method, a Policy, a dedicated class — not a reason to skip the deny-path test.
+
+---
+
+# 4. What This Skill Does NOT Do
+
+- Does not invent new authorization requirements — only checks that guards which already exist
+  in the diff are proven by tests.
+- Does not replace `security-review`'s job of spotting where a guard is *missing* entirely.
+- Does not apply to routine Filament form validation (`->required()`, `->rule()`, etc.) — that
+  has its own established test conventions in this codebase and isn't the failure mode this
+  skill targets.

.github/DOCKER.md

@@ -44,21 +44,38 @@ Visit: http://localhost:8080 (override the port with `APP_PORT` in `.env`).
 
 Both PHP images ship the full extension set the app needs: `intl`, `gd`,
 `pdo_mysql`, `bcmath`, `zip`, `exif`, `soap`, `redis`. The CLI image also has
-Composer, a 1G memory limit for the test suite, and bundled `pdo_sqlite`
-(the suite runs on an in-memory sqlite database — no db service needed for
-tests).
+Composer and a 1G memory limit for the test suite.
 
 ---
 
 ## Running the test suite
 
 ```bash
-docker compose run --rm cli vendor/bin/phpunit --exclude-group failing,troubleshooting
+docker compose run --rm cli php artisan test --exclude-group failing,troubleshooting
 ```
 
-`APP_ENV=testing` is the `cli` service default, so `.env.testing`
-(sqlite `:memory:`) is picked up automatically. See `RUNNING_TESTS.md` for
-filters, groups, and suites.
+Use `php artisan test`, not `vendor/bin/phpunit` directly — the two have been observed to behave
+differently for this app: a raw `vendor/bin/phpunit` run silently drops some submitted field
+values in Livewire form tests. `artisan test` is the proven-reliable path and is what CI uses, so
+standardize on it.
+
+**Known issue (see [#689](https://github.com/InvoicePlane/InvoicePlane-v2/issues/689)):** a
+freshly-`docker compose build`'t `cli` image has, at least once, reproduced this same
+field-dropping bug at scale (100+ false failures) even under `artisan test`, for reasons not yet
+isolated — despite extension/ini parity with a known-good image. Before trusting a full local run
+from a rebuilt `cli` image, sanity-check it against a small, known test first, e.g.:
+```bash
+docker compose run --rm cli php artisan test --filter=ContactsTest
+```
+All 11 assertions should pass. If any fail with "field is required" errors on data you know you
+supplied, don't trust the rest of that run — see the linked issue.
+
+`APP_ENV=testing` is the `cli` service default, and it always connects to
+the compose stack's real `db` service (MariaDB) for tests — the `cli`
+service injects `DB_CONNECTION=mysql`/`DB_HOST=db`/etc. itself, so nothing
+in `.env.testing` needs editing. This intentionally does not fall back to
+SQLite: SQLite's lenient identifier quoting has masked real bugs before that
+only surfaced against MariaDB in CI.
 
 ### File ownership on Linux
 

.github/workflows/phpunit.yml

@@ -51,4 +51,9 @@ jobs:
         run: php artisan migrate --force --env=testing
 
       - name: Run PHPUnit
+        # No --exclude-group flag here on purpose: passing it explicitly on the
+        # CLI was found to override (not add to) phpunit.xml's own <groups>
+        # <exclude> config, causing failing/flaky/troubleshooting-tagged tests
+        # to run anyway — confirmed by testing both ways. phpunit.xml's own
+        # config already excludes them; rely on that instead.
         run: php artisan test --env=testing

AGENTS.md

@@ -10,10 +10,9 @@ Laravel 11 + Filament v4 + Livewire v3 invoicing app. Modular architecture via `
 composer install
 cp .env.example .env && php artisan key:generate
 php artisan migrate && php artisan db:seed
-# Tests (no MySQL locally? use SQLite)
+# Tests run against real MariaDB — no SQLite fallback (parity with CI)
 cp .env.testing.example .env.testing
-# set DB_CONNECTION=sqlite, DB_DATABASE=:memory: in .env.testing
-php artisan test
+docker compose run --rm cli php artisan test --exclude-group failing,troubleshooting
 ```
 
 ---

CLAUDE.md

@@ -195,11 +195,21 @@ User::factory()->create(['is_active' => true, 'email_verified_at' => now()])
 
 ### DB for tests
 
-Tests need a DB. Production CI uses MariaDB 11. For local dev without MySQL, set in `.env.testing`:
+Tests need a real MariaDB DB — matching CI (MariaDB 11) — not SQLite. SQLite's lenient identifier
+quoting has silently masked real bugs before (e.g. `->latest()` defaulting to a nonexistent
+`created_at` column on `$timestamps = false` models passed locally, failed on CI). Run via the
+`cli` compose service, which points at the stack's `db` service automatically:
 ```
-DB_CONNECTION=sqlite
-DB_DATABASE=:memory:
+docker compose run --rm cli php artisan test --exclude-group failing,troubleshooting
 ```
+No `.env.testing` edits needed — the `cli` service injects `DB_CONNECTION=mysql`/`DB_HOST=db` etc.
+itself. Use `php artisan test`, not `vendor/bin/phpunit` directly — the two have been observed to
+behave differently for this app's Livewire form tests; `artisan test` is the reliable one.
+**Known issue:** a freshly-rebuilt `cli` image has reproduced false Livewire-form failures at
+scale even under `artisan test`, for reasons not yet isolated — see
+[#689](https://github.com/InvoicePlane/InvoicePlane-v2/issues/689) and sanity-check with
+`--filter=ContactsTest` (should be 11/11 passing) before trusting a full run from a rebuilt image.
+See `.github/DOCKER.md`.
 
 ### AAA phase comment style
 

Makefile

@@ -2,6 +2,13 @@
 ## InvoicePlane v2 — Development Makefile
 ## ──────────────────────────────────────────────────────────────────────────────
 ##
+## NOTE: `vendor/bin/phpunit` (used by the targets below) and `php artisan
+## test` (make artisan-test) have been observed to behave differently for
+## this app — a raw phpunit run has silently dropped submitted field values
+## in Livewire form tests in some environments. If a target below reports a
+## failure that `make artisan-filter FILTER="..."` doesn't reproduce, prefer
+## the artisan-test variant; it matches what CI runs.
+##
 ## QUICK START
 ##   make test          Run the full PHPUnit suite (all tests)
 ##   make smoke         Run only @group smoke tests (fast sanity check)

Modules/Clients/Database/Factories/AddressFactory.php

@@ -27,7 +27,7 @@ public function definition(): array
         return [
             'address_type'      => $this->faker->randomElement(AddressType::cases())->value,
             'address_1'         => $this->faker->streetAddress,
-            'address_2'         => $this->faker->optional(0.7)->secondaryAddress,
+            'address_2'         => $this->faker->optional(0.7)->streetAddress,
             'number'            => $this->faker->buildingNumber,
             'postal_code'       => $this->faker->postcode,
             'city'              => $this->faker->city,

Modules/Clients/Enums/CommunicationType.php

@@ -18,6 +18,14 @@ public static function values(): array
         return array_column(self::cases(), 'value');
     }
 
+    /**
+     * Communication types that should receive a CC copy of invoice emails.
+     */
+    public static function ccTypes(): array
+    {
+        return [self::INVOICE_CC->value];
+    }
+
     public function label(): string
     {
         return match ($this) {

Modules/Clients/Filament/Company/Resources/Relations/RelationManagers/NotesRelationManager.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace Modules\Clients\Filament\Company\Resources\Relations\RelationManagers;
+
+use Filament\Actions\DeleteAction;
+use Filament\Actions\EditAction;
+use Filament\Forms\Components\Textarea;
+use Filament\Resources\RelationManagers\RelationManager;
+use Filament\Schemas\Schema;
+use Filament\Tables\Columns\TextColumn;
+use Filament\Tables\Table;
+use Modules\Core\Enums\UserRole;
+
+class NotesRelationManager extends RelationManager
+{
+    protected static string $relationship = 'notes';
+
+    public function form(Schema $schema): Schema
+    {
+        return $schema->components([
+            Textarea::make('content')
+                ->required()
+                ->columnSpanFull(),
+        ]);
+    }
+
+    public function table(Table $table): Table
+    {
+        return $table
+            ->columns([
+                TextColumn::make('content')->wrap(),
+                TextColumn::make('noted_at')->dateTime(),
+            ])
+            ->recordActions([
+                EditAction::make()->authorize(fn (): bool => $this->canManageNotes()),
+                DeleteAction::make()->authorize(fn (): bool => $this->canManageNotes()),
+            ]);
+    }
+
+    protected function canManageNotes(): bool
+    {
+        return auth()->user()?->hasAnyRole([
+            UserRole::CUSTOMER_ADMIN->value,
+            ...UserRole::elevated(),
+        ]) ?? false;
+    }
+}

Modules/Clients/Filament/Company/Resources/Relations/RelationResource.php

@@ -16,6 +16,7 @@
 use Modules\Clients\Filament\Company\Resources\Relations\Pages\ViewRelation;
 use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\ExpensesRelationManager;
 use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\InvoicesRelationManager;
+use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\NotesRelationManager;
 use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\ProjectsRelationManager;
 use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\QuotesRelationManager;
 use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\TasksRelationManager;
@@ -76,6 +77,7 @@ public static function getRelations(): array
             ExpensesRelationManager::class,
             TasksRelationManager::class,
             ProjectsRelationManager::class,
+            NotesRelationManager::class,
         ];
     }
 

Modules/Clients/Models/Relation.php

@@ -16,6 +16,7 @@
 use Modules\Clients\Enums\RelationStatus;
 use Modules\Clients\Enums\RelationType;
 use Modules\Core\Models\Company;
+use Modules\Core\Models\Note;
 use Modules\Core\Models\User;
 use Modules\Core\Traits\BelongsToCompany;
 use Modules\Expenses\Models\Expense;
@@ -118,7 +119,7 @@ public function communications(): MorphMany
 
     public function ccEmailCommunications(): MorphMany
     {
-        return $this->communications()->where('communication_type', CommunicationType::INVOICE_CC->value);
+        return $this->communications()->whereIn('communication_type', CommunicationType::ccTypes());
     }
 
     public function contacts(): HasMany
@@ -141,6 +142,11 @@ public function invoices(): HasMany
         return $this->hasMany(Invoice::class, 'customer_id');
     }
 
+    public function notes(): MorphMany
+    {
+        return $this->morphMany(Note::class, 'notable');
+    }
+
     public function payments(): HasMany
     {
         return $this->hasMany(Payment::class, 'customer_id');

Modules/Clients/Tests/Feature/NotesRelationManagerTest.php

@@ -0,0 +1,67 @@
+<?php
+
+namespace Modules\Clients\Tests\Feature;
+
+use Livewire\Livewire;
+use Modules\Clients\Filament\Company\Resources\Relations\Pages\ViewRelation;
+use Modules\Clients\Filament\Company\Resources\Relations\RelationManagers\NotesRelationManager;
+use Modules\Clients\Models\Relation;
+use Modules\Core\Tests\AbstractCompanyPanelTestCase;
+use PHPUnit\Framework\Attributes\Test;
+
+class NotesRelationManagerTest extends AbstractCompanyPanelTestCase
+{
+    #[Test]
+    public function it_edits_a_client_note(): void
+    {
+        /* Arrange */
+        $client = Relation::factory()->for($this->company)->customer()->create();
+        $note   = $client->notes()->create([
+            'company_id' => $this->company->id,
+            'user_id'    => $this->user->id,
+            'noted_at'   => now(),
+            'is_private' => false,
+            'title'      => 'Client note',
+            'content'    => 'Original note',
+        ]);
+
+        /* Act */
+        $component = Livewire::actingAs($this->user)
+            ->test(NotesRelationManager::class, [
+                'ownerRecord' => $client,
+                'pageClass'   => ViewRelation::class,
+            ])
+            ->callTableAction('edit', $note, data: ['content' => 'Updated note']);
+
+        /* Assert */
+        $component->assertHasNoTableActionErrors();
+        $this->assertDatabaseHas('notes', ['id' => $note->id, 'content' => 'Updated note']);
+    }
+
+    #[Test]
+    public function it_deletes_a_client_note(): void
+    {
+        /* Arrange */
+        $client = Relation::factory()->for($this->company)->customer()->create();
+        $note   = $client->notes()->create([
+            'company_id' => $this->company->id,
+            'user_id'    => $this->user->id,
+            'noted_at'   => now(),
+            'is_private' => false,
+            'title'      => 'Client note',
+            'content'    => 'Delete me',
+        ]);
+
+        /* Act */
+        $component = Livewire::actingAs($this->user)
+            ->test(NotesRelationManager::class, [
+                'ownerRecord' => $client,
+                'pageClass'   => ViewRelation::class,
+            ])
+            ->callTableAction('delete', $note);
+
+        /* Assert */
+        $component->assertHasNoTableActionErrors();
+        $this->assertDatabaseMissing('notes', ['id' => $note->id]);
+    }
+}

Modules/Core/Filament/Company/Pages/MyCompanies.php

@@ -13,6 +13,7 @@
 use Modules\Core\Enums\UserRole;
 use Modules\Core\Models\Company;
 use Modules\Core\Models\User;
+use Modules\Core\Services\UserService;
 
 class MyCompanies extends Page implements HasTable
 {
@@ -45,7 +46,13 @@ public function table(Table $table): Table
                 Action::make('switch')
                     ->label(trans('ip.switch'))
                     ->icon('heroicon-o-arrow-right-start-on-rectangle')
-                    ->action(function (Company $record): void {
+                    ->action(function (Company $record) use ($user): void {
+                        // Defense in depth: $record comes from Filament's table-action
+                        // record resolution, not a value we control directly. Refuse
+                        // to switch into a company the user isn't actually a member
+                        // of, regardless of how $record got resolved.
+                        app(UserService::class)->assertBelongsToCompany($user, $record);
+
                         session(['current_company_id' => $record->id]);
                         Filament::setTenant($record);