Skip to content

chore(audit): codebase audit 2026-08-09 — review --max (47 follow-ups) - #795

Closed
unohee wants to merge 4 commits into
mainfrom
swarm/AGT-3455-chore-audit-codebase-audit-2026-08-09-re
Closed

unohee wants to merge 4 commits into
mainfrom
swarm/AGT-3455-chore-audit-codebase-audit-2026-08-09-re

Conversation

@unohee

@unohee unohee commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Published because this run stopped and needs a human: autonomous execution failed 4 times

It has not been reviewed and is very likely incomplete — this PR is a draft on purpose. It exists so the work is reviewable instead of sitting on a branch that was never pushed.

Change shape

517 file(s): 262 source · 234 test · 4 docs · 17 other

Base freshness

Branch base is 180 commit(s) behind main at publication.

⚠ Conflicts with main in: package-lock.json, package.json, src/adapters/rateLimitError.ts, src/automation/dailyReporter.ts, src/discord/discordCore.ts, src/discord/discordPair.ts, src/locale/prompts/en.ts, src/locale/prompts/ko.ts, src/support/gitStatus.ts, src/task_state_model.py, src/tui/components/AuditBoard.tsx, src/tui/components/ChatLog.tsx
GitHub runs no pull_request workflows on a PR it cannot merge, so any green checks here are not the verification gate. Opened as a draft; rebase before review.

⚠️ File overlap with in-flight work

This branch changes files that other open PRs / active branches also touch. Coordinate before merging to avoid divergent parallel edits (INT-2388 #3):

  • PR release: publish 0.24.4 — audit remediation port + durable review-verdict reuse #794 (feat/omp-agent-patterns-v2) — 6 file(s): src/adapters/tools.ts, src/agents/verificationEvidence.test.ts, src/agents/verificationEvidence.ts, src/automation/dailyReporter.ts, src/locale/prompts/en.ts, src/task_state_model.py
  • PR chore(audit): codebase audit 2026-08-09 — review --max (40 follow-ups) #792 (swarm/AGT-3485-chore-audit-codebase-audit-2026-08-09-re) — 9 file(s): package-lock.json, package.json, src/adapters/tools.test.ts, src/adapters/tools.ts, src/agents/verificationEvidence.test.ts, src/agents/verificationEvidence.ts, src/automation/dailyReporter.ts, src/support/dashboardHtml.test.ts (+1 more)
  • branch origin/swarm/AGT-3417-fix-async-ui-contain-rejected-commands-a — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-3420-fix-state-make-task-and-graph-state-upda — 3 file(s): package-lock.json, package.json, src/task_state_model.py
  • branch origin/swarm/AGT-3422-fix-output-enforce-aggregate-output-budg — 4 file(s): package-lock.json, package.json, src/runners/cliRunner.ts, src/tui/components/AuditBoard.tsx
  • branch origin/swarm/AGT-3423-fix-execution-bound-subprocesses-and-uni — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-3428-fix-validation-harden-persisted-and-comm — 3 file(s): src/adapters/tools.test.ts, src/adapters/tools.ts, src/task_state_model.py
  • branch origin/swarm/AGT-3429-fix-streaming-bound-event-and-subprocess — 3 file(s): package-lock.json, src/discord/discordPair.ts, src/runners/cliRunner.ts
  • branch origin/swarm/AGT-3433-fix-automation-constrain-issue-and-deliv — 2 file(s): src/agents/workerValidationEvidence.test.ts, src/agents/workerValidationEvidence.ts
  • branch origin/swarm/AGT-3434-perf-knowledge-memory-bound-graph-discov — 2 file(s): package-lock.json, package.json
  • branch origin/swarm/AGT-3442-fix-integrations-validate-provider-and-c — 3 file(s): package-lock.json, src/adapters/rateLimitError.test.ts, src/adapters/rateLimitError.ts
  • branch origin/swarm/AGT-3444-fix-state-protect-persisted-issue-memory — 2 file(s): package-lock.json, package.json
  • branch origin/swarm/AGT-3446-fix-output-sanitize-and-budget-rendered- — 9 file(s): package-lock.json, package.json, src/discord/discordPair.ts, src/locale/prompts/en.ts, src/locale/prompts/ko.ts, src/locale/prompts/prompts.test.ts, src/runners/cliRunner.ts, src/support/dashboardHtml.ts (+1 more)
  • branch origin/swarm/AGT-3447-fix-repository-harden-filesystem-git-and — 3 file(s): package-lock.json, src/support/gitStatus.test.ts, src/support/gitStatus.ts
  • branch origin/swarm/AGT-3457-fix-state-persistence-make-state-transit — 3 file(s): package-lock.json, src/automation/dailyReporter.ts, src/task_state_model.py
  • branch origin/swarm/AGT-3465-fix-external-integrations-bound-and-sani — 1 file(s): src/discord/discordCore.ts
  • branch origin/swarm/AGT-3468-fix-automation-state-make-workflow-and-b — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-3473-fix-graphql-costing-account-for-aliased- — 2 file(s): package-lock.json, package.json
  • branch origin/swarm/AGT-3486-fix-tool-boundaries-harden-command-guard — 7 file(s): package-lock.json, package.json, src/adapters/tools.ts, src/agents/verificationEvidence.ts, src/locale/prompts/en.ts, src/locale/prompts/ko.ts, src/task_state_model.py
  • branch origin/swarm/AGT-3489-fix-state-integrity-make-operational-sta — 1 file(s): src/automation/dailyReporter.ts
  • branch origin/swarm/AGT-3491-fix-memory-make-retrieval-compaction-and — 2 file(s): package-lock.json, package.json
  • branch origin/swarm/AGT-3492-fix-network-access-restrict-notification — 2 file(s): package-lock.json, package.json
  • branch origin/swarm/AGT-3493-fix-support-output-safely-render-dashboa — 1 file(s): src/support/dashboardHtml.ts
  • branch origin/swarm/AGT-3495-fix-auto-linking-release-deadline-limite — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4008-feature-implement-authenticated-github-r — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4024-feat-task-state-replace-the-dot-lock-wit — 2 file(s): package-lock.json, package.json
  • branch origin/swarm/AGT-4027-bug-an-operator-reply-queues-behind-agen — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4045-feat — 5 file(s): package-lock.json, package.json, src/locale/prompts/en.ts, src/locale/prompts/ko.ts, src/locale/prompts/prompts.test.ts
  • branch origin/swarm/AGT-4059-bug-dashboard-s-latestaddressable-can-ta — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4128-feature-warehouse-a-single-agent-explora — 2 file(s): package-lock.json, src/adapters/tools.test.ts
  • branch origin/swarm/AGT-4153-bug-coordinationtools-test-asserts-an-un — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4160-fix-security-audit-remove-codeql-from-th — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4182-meta-autodeploy-lane-on-vela-merged-main — 1 file(s): package-lock.json
  • branch origin/swarm/AGT-4232-fix-adapters-provider-role-split — 2 file(s): package-lock.json, package.json
  • ⚠️ MERGED PR fix(streaming): bound SSE payloads, sockets, streams and subprocesses (salvage #759, #762, #765) #789 (salvage/streaming-bounds) — not in this branch's history, verify its fix wasn't dropped — 2 file(s): src/support/gitStatus.test.ts, src/support/gitStatus.ts
  • ⚠️ MERGED PR fix(boundaries): harden DNS pinning, GraphQL cost limits, and CLI/provider validation (salvage #764, #774, #778) #788 (salvage/boundaries) — not in this branch's history, verify its fix wasn't dropped — 2 file(s): src/adapters/rateLimitError.test.ts, src/adapters/rateLimitError.ts
  • ⚠️ MERGED PR fix(output): unify sanitize/budget layer across Discord, TUI, CLI, and agents (salvage #758+#775+#782) #787 (salvage/output-sanitize) — not in this branch's history, verify its fix wasn't dropped — 8 file(s): src/discord/discordCore.ts, src/discord/discordPair.ts, src/locale/prompts/en.ts, src/locale/prompts/ko.ts, src/locale/prompts/prompts.test.ts, src/runners/cliRunner.ts, src/tui/components/AuditBoard.tsx, src/tui/components/ChatLog.tsx
  • ⚠️ MERGED PR fix(state-integrity): salvage durable state fences + review quality harness (#757 #771 #773 #777) #786 (salvage/state-review) — not in this branch's history, verify its fix wasn't dropped — 3 file(s): src/agents/workerValidationEvidence.test.ts, src/agents/workerValidationEvidence.ts, src/automation/dailyReporter.ts
  • ⚠️ MERGED PR fix(support-output): safely render dashboard values and decode Git streams — prevent injection and corrupted repository state #770 (swarm/AGT-3493-fix-support-output-safely-render-dashboa) — not in this branch's history, verify its fix wasn't dropped — 1 file(s): src/support/dashboardHtml.ts
  • ⚠️ MERGED PR test: stop unit tests and comments from carrying the pipeline eval's answers (AGT-4534) #746 (fix/remove-eval-answer-keys) — not in this branch's history, verify its fix wasn't dropped — 1 file(s): src/agents/workerValidationEvidence.test.ts
  • ⚠️ MERGED PR fix(pair-pipeline): verify a worker's blocker claim even when it kept edits (AGT-4535) #730 (fix/blocker-with-edits) — not in this branch's history, verify its fix wasn't dropped — 2 file(s): src/locale/prompts/en.ts, src/locale/prompts/ko.ts
  • ⚠️ MERGED PR feat(agents): verify a worker's no-edit blocker claim with the reviewer instead of retrying (AGT-4535) #724 (feat/worker-blocker-review) — not in this branch's history, verify its fix wasn't dropped — 2 file(s): src/locale/prompts/en.ts, src/locale/prompts/ko.ts
  • ⚠️ MERGED PR fix(agents): judge worker validation by observed execution, not self-report (AGT-4534) #722 (fix/native-loop-execution-evidence) — not in this branch's history, verify its fix wasn't dropped — 4 file(s): src/adapters/tools.test.ts, src/adapters/tools.ts, src/agents/workerValidationEvidence.test.ts, src/agents/workerValidationEvidence.ts
  • ⚠️ MERGED PR feat(adapters): Ollama Cloud adapter with per-transport model ids (AGT-4512) #720 (feat/ollama-cloud-adapter) — not in this branch's history, verify its fix wasn't dropped — 1 file(s): src/support/dashboardHtml.ts
  • ⚠️ MERGED PR release: publish 0.24.2 #715 (heewonoh/agt-4484-release-0-24-2) — not in this branch's history, verify its fix wasn't dropped — 2 file(s): package-lock.json, package.json

Linear

Closes AGT-3455


🤖 Generated with OpenSwarm

@unohee

unohee commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as a duplicate remediation of the same 2026-08-09 audit. Two problems, both verified:

  1. Competing with itself. PR chore(audit): codebase audit 2026-08-09 — review --max (40 follow-ups) #792 (AGT-3485 / 40 follow-ups, +1125/-206 across 44 files) and PR chore(audit): codebase audit 2026-08-09 — review --max (47 follow-ups) #795 (AGT-3455 / 47 follow-ups, +731/-996 across 40 files) are the daemon independently re-fixing overlapping findings from the same audit batch. Both are CONFLICTING against main, and they touch the same files (src/adapters/tools.ts, src/agents/verificationEvidence.ts, src/automation/dailyReporter.ts, package.json), so neither can merge without invalidating the other.

  2. Non-source junk committed. chore(audit): codebase audit 2026-08-09 — review --max (47 follow-ups) #795 adds .tmp_git_probe.py; chore(audit): codebase audit 2026-08-09 — review --max (40 follow-ups) #792 adds .cursor/cli.json.bak, .cursor/.gitkeep, and a file literally named {\"permissions\":{...}} (a JSON blob used as a filename). Whatever is salvaged must not carry these.

Most of what was worth keeping already reached main through the earlier salvage PRs (#785-#791) — that is why the corresponding cards were canceled after re-verification against origin/main today. The remainder is re-scoped onto the surviving cards under the Audit Residuals (2026-08-09) milestone.

PR #794 carries the ported remainder and is MERGEABLE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant