Skip to content

Add aggregator CLI commands for configuration parameters - #3438

Draft
turmelclem wants to merge 13 commits into
mainfrom
ctl/3392-add-aggregator-CLI-command-for-configuration-parameters
Draft

Add aggregator CLI commands for configuration parameters#3438
turmelclem wants to merge 13 commits into
mainfrom
ctl/3392-add-aggregator-CLI-command-for-configuration-parameters

Conversation

@turmelclem

@turmelclem turmelclem commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Content

⚠️ work in progress ⚠️

aggregator cli :

  • import command TODO
  • export command generating datum file from a JSON file
    • verifying user JSON file consistency (non zero values, configurations and enabled signed entity type consistency)
    • verifying configuration to import against configuration on chain TODO
    • checking datum that not exceed 10kb (since a full cardano transaction is 16kb) TODO
    • writing a JSON HEX datum file at given path

protocol-config

  • a adapter trait that is used by aggregagtor cli to retrieve information about protocol configuration markers
    • with the intelligence to retrieve the configuration of the nearest known epoch
  • cbor encoding/decoding of marker configuration

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

this PR closes #3392

@turmelclem turmelclem self-assigned this Jul 27, 2026
}

/// Cardano Chain adapter retrieves protocol configuration markers on chain
pub struct CardanoChainAdapter {

/// Cardano Chain adapter retrieves protocol configuration markers on chain
pub struct CardanoChainAdapter {
address: ChainAddress,
/// Cardano Chain adapter retrieves protocol configuration markers on chain
pub struct CardanoChainAdapter {
address: ChainAddress,
chain_observer: Arc<dyn ChainObserver>,
pub struct CardanoChainAdapter {
address: ChainAddress,
chain_observer: Arc<dyn ChainObserver>,
verification_key: ProtocolConfigurationMarkersVerifierVerificationKey,

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Test Results

     5 files  ± 0     209 suites  ±0   1h 0m 56s ⏱️ - 54m 30s
 3 349 tests  - 24   3 349 ✅  - 24  0 💤 ±0  0 ❌ ±0 
11 150 runs  +42  11 150 ✅ +42  0 💤 ±0  0 ❌ ±0 

Results for commit 70d124f. ± Comparison against base commit 8bbdf2d.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement aggregator CLI commands for configuration parameters

2 participants