feat(common): encode the SNARK aggregate signature as bytes in the certificate message - #3437
Draft
jpraynaud wants to merge 1 commit into
Draft
feat(common): encode the SNARK aggregate signature as bytes in the certificate message#3437jpraynaud wants to merge 1 commit into
jpraynaud wants to merge 1 commit into
Conversation
Encode the multi-signature by type: JSON-hex for concatenation (backward compatible), bytes-hex for SNARK and IVC proofs.
jpraynaud
temporarily deployed
to
testing-2-preview
July 27, 2026 15:37 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-preview
July 27, 2026 15:37 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the encoding of the certificate message aggregate signature by type, so SNARK and IVC proofs use the compact bytes-hex encoding while concatenation proofs remain backward compatible:
multi_signaturefield by aggregate signature type: JSON-hex for concatenation proofs (backward compatible with all deployed clients) and bytes-hex for SNARK and IVC proofs.ProtocolKeycodec (String::try_from) instead of an explicit bytes-hex call.Pre-submit checklist
Issue(s)
Closes #3379