tracer: remove RTView#6607
Open
Russoul wants to merge 4 commits into
Open
Conversation
RTView was an experimental opt-in browser dashboard hidden behind a `flag rtview` cabal flag and `#if RTVIEW` CPP guards. It was unused and its dependencies (threepenny-gui, cassava, string-qq, etc.) added maintenance burden with no benefit. - Delete all 35 RTView source files under Handlers/RTView/ - Remove `flag rtview` and all conditional blocks from cardano-tracer.cabal - Remove `TracerEnvRTView` from the type system and all call sites - Remove `hasRTView` from TracerConfig and all config files/examples - Remove RTView NixOS options and workbench integration - Remove 4 rtview-named bench profiles; strip `rtview` field from the rest - Rename bench/grafana-datasource/dashboards/rtview-port.json to node-metrics.json (panels use iog-cardanotimeseries-datasource, not RTView) - Remove RTView documentation
Russoul
force-pushed
the
russoul/purge-rtview
branch
from
fbf0d16 to
d547855
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RTView was an experimental opt-in browser dashboard in
cardano-tracer, hidden behind aflag rtviewcabal flag and#if RTVIEWCPP guards since 0.2.4. It is unused and its dependencies add maintenance burden with no benefit.The functionality RTView provided is fully covered by the Grafana datasource plugin coupled with the timeseries server built into
cardano-tracer.Handlers/RTView/)flag rtview, all#if RTVIEWCPP guards, and RTView-only build-depends (threepenny-gui,cassava,string-qq,cardano-git-rev,utf8-string)TracerEnvRTViewfrom the type system and all call siteshasRTViewfromTracerConfigand all config files/examplesHandlers.Systemthat served RTView UI onlyrtviewEnable,rtviewHost,rtviewPort) and workbench integration*-rtviewbench profiles; strip thertviewfield fromcardano-profile'sTracertype and all remaining profilesbench/grafana-datasource/dashboards/rtview-port.json→node-metrics.json(panels useiog-cardanotimeseries-datasource, not RTView)cardano-tracerto 0.6.0