wip: refactor data evaluators & add kg evaluators

[ChenZiHong-Gavin]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ChenZiHong-Gavin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates a significant refactoring of the evaluator architecture by relocating the core BaseEvaluator class to a more foundational bases directory. This change aims to improve the modularity and organization of the codebase, preparing it for the integration of new evaluator types, particularly Knowledge Graph (KG) evaluators, as part of an ongoing work-in-progress effort.

Highlights

• Evaluator Base Class Relocation: The BaseEvaluator class has been moved from graphgen/models/evaluator/ to graphgen/bases/ to establish a more fundamental base for evaluators.
• Dependent Evaluator Updates: Existing evaluators, specifically LengthEvaluator and MTLDEvaluator, have been updated to reflect the new import path for the BaseEvaluator.
• Future KG Evaluator Integration: This refactoring lays the groundwork for the future addition of Knowledge Graph (KG) evaluators, as indicated by the PR title.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the data evaluators by moving BaseEvaluator to a more suitable bases directory and updating the corresponding imports in LengthEvaluator and MTLDEvaluator. The changes are correct and improve the project structure. The import reordering also aligns with common style guides. I have reviewed the code changes and found no issues.

The PR title suggests this is a work-in-progress, mentioning the addition of 'kg evaluators' which are not yet present. I also observed that RewardEvaluator and UniEvaluator do not yet inherit from BaseEvaluator. Unifying all evaluators under this common base class would be a valuable next step for consistency.