fix: treat [checked] as bool like disabled - #87
Merged
gRoussac merged 1 commit intoSep 23, 2026
Merged
Conversation
prop_str("false") was truthy in the DOM; banana writeback now uses
(change) + el.checked → Value::Bool. Dogfood in two-way demo.
Closes Interchouette-ITC#85
Co-authored-by: Cursor <cursoragent@cursor.com>
gRoussac
approved these changes
Sep 23, 2026
gRoussac
added a commit
to gRoussac/horto-os-ui
that referenced
this pull request
Sep 23, 2026
Pick up Interchouette-ITC/rangular#87 so Connection checkboxes render and write real bools instead of truthy "false" strings. Co-authored-by: Cursor <cursoragent@cursor.com>
gRoussac
added a commit
to Hortos-Network/horto-os-ui
that referenced
this pull request
Sep 23, 2026
* feat(remote): gate setup on current tip CLI and expose cli_version Refuse remote setup when the box agent is behind Desktop unless the operator opts in; strip tip-only flags for stale agents. Surface tip vs box versions in Connection with Update CLI, and report cli_version from Status API health and status for day-2 checks without SSH. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): redesign Connection CLI compare card Replace the Tip/Box/Source/Match dump with a status chip, two-pane version compare, quiet meta line, and a clear Update / allow-older row. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): fold CLI versions into Surfaces, drop compare card No lead, chip, or pane chrome. Probe + Update CLI, Desktop/Box rows only after a check, Allow older CLI under Install options. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): show CLI mismatch on one Surfaces row Drop the duplicate Desktop/Box list. When behind, CLI is box · Desktop tip (warn color); when current, box version alone. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): drop unused SurfacesUiReport.cli field Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): put Apply and Allow older CLI under Install on box Both stay off by default; keep them out of the Install options list. Co-authored-by: Cursor <cursoragent@cursor.com> * chore: bump rangular for checked bool binding Pick up Interchouette-ITC/rangular#87 so Connection checkboxes render and write real bools instead of truthy "false" strings. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): gate install on probe/CLI match and place Update feedback Lock install until probe (or Allow older when behind); show Update CLI and mismatch note with Surfaces; keep Apply under Install; route Update CLI log next to that action; pack remote setup invoke args for clippy. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(web): check/uncheck all for install options and extra apps Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): space Releases block before and after Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[checked]/[(checked)]useeval_boollike[disabled], sofalseis not a truthyprop_strin the DOM(change)+el.checked→Host::set(Value::Bool)two-wayfixture + demo-leptosCloses #85
Test plan
cargo test -p rangular-parser -p rangular-aot -p rangular-runtime(checked / two_way filters)cargo clippy -p rangular-parser -p rangular-aot -p rangular-runtime --all-targets -- -D warningscargo check --manifest-path demo-leptos/Cargo.tomltwo-waypanel (unchecked by default; Push from Host sets true)