Skip to content

fix: treat [checked] as bool like disabled - #86

Closed
gRoussac wants to merge 1 commit into
Interchouette-ITC:devfrom
gRoussac:fix/checked-bool-prop
Closed

gRoussac wants to merge 1 commit into
Interchouette-ITC:devfrom
gRoussac:fix/checked-bool-prop

Conversation

@gRoussac

Copy link
Copy Markdown
Member

Summary

  • [checked] / [(checked)] use eval_bool like [disabled], so false is not a truthy prop_str in the DOM
  • Banana writeback uses (change) + el.checked → Host::set(Value::Bool)
  • Dogfood checkbox in two-way fixture + demo-leptos

Closes #85

Test plan

  • cargo test -p rangular-parser -p rangular-aot -p rangular-runtime (checked / two_way filters)
  • cargo clippy -p rangular-parser -p rangular-aot -p rangular-runtime --all-targets -- -D warnings
  • cargo check --manifest-path demo-leptos/Cargo.toml
  • Toggle checkbox in demo-leptos two-way panel (unchecked by default; Push from Host sets true)

Made with Cursor

prop_str("false") was truthy in the DOM; banana writeback now uses
(change) + el.checked → Value::Bool. Dogfood in two-way demo.

Closes Interchouette-ITC#85

Co-authored-by: Cursor <cursoragent@cursor.com>
@gRoussac

Copy link
Copy Markdown
Member Author

Opened from wrong fork (gRoussac). Replacing with Interchouette head.

@gRoussac gRoussac closed this Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[checked] / [(checked)] treat as bool like disabled

2 participants