Repository navigation
feat(ui): redesign GPUI desktop shell chrome - #152
Merged
gRoussac merged 4 commits intoSep 19, 2026
Merged
Conversation
Replace chip toolbar with real menus, play/pause operators, Preferences modal, and bottom filter Selects. Refresh tray and GNOME icons and align the UX contract with the shipped shell.
Disposable BufReaders were eating the backlog frame already buffered with v1 subscribed, so coverage CI timed out on WouldBlock. Read byte-wise and cover the pipelined case.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Retry Interrupted reads and keep the socket peer half open for the silent-timeout test so coverage and workspace test agree.
Move SIGCHLD handling into classify_read_line so patch coverage sees it without failure-only assert arms.
gRoussac
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DropdownMenu, Preferences modal, and play/pause operator controls (phoenix on/off color semantics).Test plan
make fmt && make lint && make test(UI package green locally)interfire-ui: App menu works; Preferences modal opens; no top Preferences chipinterfireicon has no black surround; tray states read on dark panels