You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
codex worker -c overrides never reach the npm codex-acp adapter (sandbox, approval policy, reasoning effort silently dropped) #27
The worker adapter the README documents (npm install -g @agentclientprotocol/codex-acp, matching providers.py's default_worker_acp_command="codex-acp") does not parse these. Its entrypoint (verified against @agentclientprotocol/codex-acp 1.1.0 dist/index.js) inspects argv only for --version and the login / cli subcommands; a bare invocation starts the ACP server configured solely from env: CODEX_CONFIG (JSON), CODEX_PATH, MODEL_PROVIDER, DEFAULT_AUTH_REQUEST. All three -c overrides are silently discarded.
Impact
model_reasoning_effort — hardcoded xhigh today, per-role once feat(config): make codex reasoning effort configurable per role #17 lands — never reaches the worker. The adapter resolves effort from the model default instead, and clamps unsupported values to the model default (findSupportedEffort), so the misconfiguration is silent.
sandbox_mode / approval_policy intent rides only the env-var hints already present in _acp_subprocess_env (CODEX_SANDBOX, CODEX_DISABLE_SANDBOX, commented "harmless if codex ignores them") — not the adapter's actual configuration contract.
Existing tests assert the constructed command string, so the delivery failure is invisible to CI.
Proposed fix
Build CODEX_CONFIG JSON in _acp_subprocess_env for codex workers (merging any user-supplied CODEX_CONFIG), carrying sandbox mode, approval policy, and reasoning effort; wire the per-role effort values from #17 once it lands. Happy to send that PR.
One question first
If a different codex-acp build (e.g. a -c-honoring binary) is the canonical adapter in your setups, the fix should target whichever contract you consider supported — please confirm which adapter Zenith targets.
Found while amending #17; verified locally against the npm adapter 1.1.0 (Windows install, global npm).
Activity
stephanbrez commentedon Jul 19, 2026
Another suggestion here, if you're going to be plumbing those in, also add support for specifying model names e.g. '-c model="gpt-5.6-luna"',
feat(observability): log ACP spawn command + CODEX_CONFIG per dispatch
fix(acp): route codex -c overrides through CODEX_CONFIG for npm adapter
fix(acp): integrate Intelligent-Internet#31 with robust Codex config…