Clear the static-analysis findings on the dev-to-main PR - #138
Merged
Merged
Conversation
…e UI text, the PKCS#8 header is a format marker, the main window reference is released explicitly after exec
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codacy and SonarCloud failed on #137 (dev to main). All but one finding are false positives, marked inline the way the repo already does (
# nosec/# nosemgrep/# NOSONARwith a reason):_PKCS8_PLAIN: the PEM header used to recognise a PKCS#8 file, not a key._exact_float: Decimal compares by value, so the condition is false for any number that round-trips.The real one:
main_ui.pykept the window in an unused local (F841). It is now released explicitly afterexec(), which keeps the same lifetime.Related tests pass locally (375).