Fix the findings of the 2026-09-07T20-56 code style analysis - #18
Merged
Conversation
- M: zero `!!` in the test suite - the sender context exposes a checked `recorder` accessor, the Micrometer tests look meters up through a `gauge` helper next to the existing `counter`/`timer` ones, the appender tests use `checkNotNull` with a message - M: MetricsBindings.bindBreakerMeters registers its breaker gauges and call timers through two small helpers instead of eleven hand-unrolled builder chains (names, tags and descriptions unchanged) - L: ADR-0001 prefixes on the rationale comments added on 2026-09-07 - L: Given/When/Then markers on the three tests that lacked them; the documentation-contract tests get their @nested group - L: closeInParallel is a top-level function like the module's other stateless helper - L: the dispatcher skeleton's worker is a property initializer, as in the house pattern - L: rationale comments on the two hand-managed `open` classes in the test support - L: SynchronizingProducerFactory replaces the last `Test…Factory` name Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GfdGp7eUrjJKBvcJUx3q2
Third-round style and idiomatics audit at 683850c (0 Critical, 0 High, 2 Medium, 6 Low, 2 systemic patterns); every finding carries its status line referencing the fix commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GfdGp7eUrjJKBvcJUx3q2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediation of
docs/assessment/CODE_STYLE-2026-09-07T20-56-00.md(third style round at683850c: 2 Medium, 6 Low, 2 patterns), per the review workflow: fix commit first, then the report with per-finding status lines.Fixed
!!in the test suite (29 → 0) - a checkedrecorderaccessor on the sender context, agaugelookup helper in the Micrometer tests,checkNotNullwith messages in the appender tests.MetricsBindings.bindBreakerMetersregisters its meters through two small helpers instead of eleven hand-unrolled builder chains; names, tags and descriptions unchanged.@Nestedgroup in the documentation-contract test.closeInParallelas a top-level function.openclasses in the test support.SynchronizingProducerFactoryreplaces the lastTest…Factoryname.mvn verify(offline, incl. ktlint): 267 tests green.🤖 Generated with Claude Code
https://claude.ai/code/session_015GfdGp7eUrjJKBvcJUx3q2