Fix the findings of the 2026-09-07T19-09 R2 follow-up analysis - #16
Merged
Conversation
- M: an event whose MDC cannot be materialized (LoggerContext without an MDC adapter) gets an empty MDC snapshot pinned in append(), and the default partitioning-key extractor treats an unreadable MDC as "no key" - the appender delivers instead of diverting every event as encoder.error (mutation-checked) - L: the configuration guide describes the fallback dispatcher's two-phase close (full 5 s drain, then interrupt + 0.5 s grace) - L: README, guide and KDoc no longer promise a per-class breaker override that the internal registry seam (ADR-0002) cannot deliver - L: KafkaAppenderMetricsBinding decides on the appender's own bound state (isMeterRegistryBound) instead of instance identity, so a restarted appender is bound again by bindAppenders() - L: a restart resets the breakers the previous life left behind (identity kept for the metrics consumers) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GfdGp7eUrjJKBvcJUx3q2
…tatus Follow-up pass (round 2) at ec49b24: 1 Medium, 4 Low, 1 new systemic pattern, no severity change to the initial report; every new finding carries its status line referencing the fix commit 5d849c8. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GfdGp7eUrjJKBvcJUx3q2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediation of
docs/assessment/CODE_ANALYSIS-2026-09-07T19-09-00.R2.md(follow-up pass atec49b24: 1 Medium, 4 Low, 1 pattern), per the review workflow: fix commit5d849c8first, then the report with per-finding status lines.Fixed
append()pins an empty MDC snapshot and the default key extractor treats an unreadable MDC as "no key" (mutation-checked).KafkaAppenderMetricsBindingdecides on the appender's bound state instead of instance identity, so a restarted appender is bound again bybindAppenders().Deliberately incremental
mvn verify(offline, incl. ktlint): 268 tests green.🤖 Generated with Claude Code
https://claude.ai/code/session_015GfdGp7eUrjJKBvcJUx3q2