fix: partial write error handling - #66
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 83.32% 83.97% +0.65%
==========================================
Files 10 10
Lines 2027 2141 +114
==========================================
+ Hits 1689 1798 +109
- Misses 338 343 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2ae0091 to
f13af3f
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Documentation, error formatting, API compatibility, and skipped or incorrect test assertions remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Updates partial-write error parsing and adds V2/V3 integration coverage.
Changes:
- Adds structured partial-write messages and optional line numbers.
- Expands write-error classification and response parsing.
- Adds mock-server and end-to-end tests.
| File | Summary |
|---|---|
tests/write_tests.rs |
Adds response classification cases. |
tests/client.rs |
Adds V2, V3, and partial-write tests. |
src/error.rs |
Updates partial-write error structures. |
src/client.rs |
Parses and classifies write errors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
8611ff6 to
6587b9c
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A test has a compile error, and several tests can pass without verifying the expected errors.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Resolved since last review (3)
96b71ef to
0c383ab
Compare
0b1f4a4 to
47f34f8
Compare
0494e82 to
719f8bd
Compare
karel-rehor
left a comment
There was a problem hiding this comment.
Looks good to me. 🚴 🏁



Closes #
Proposed Changes
Changes
- Error response status code is
400.- Error response format
{"error":"...","data":[{"error_message":"...","line_number":2,"original_line": "..."}]}is returned withdatamust be an array.-
accept_partialis set totrue.- Write endpoint must be
api/v3/write_lp.Checklist