Add per-tab option to set a default input channel without locking it - #195
Open
Fasted93 wants to merge 1 commit into
Open
Add per-tab option to set a default input channel without locking it#195Fasted93 wants to merge 1 commit into
Fasted93 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now a tab's "Input channel" is enforced every frame and the channel switcher is disabled. With no input channel set, the tab just inherits whatever channel the game picks on login, which is usually Novice Network.
This adds a "Lock input channel" checkbox per tab. It defaults to on, so existing configs behave exactly as before.
When unchecked, the selected channel is applied when switching to the tab and a few seconds after login, but you can still change the channel afterwards through the switcher, keybinds or commands.
Changes:
LockChannelfield onTab(defaulttrue, no config migration needed)Loginevent. I used a 3 second delay; if that turns out to be too short on some setups, bumping it to 5 should be safe