Repository navigation
ci: run the tests and build on pull requests - #52
Closed
scott-ray-wilson wants to merge 1 commit into
Closed
scott-ray-wilson wants to merge 1 commit into
scott-ray-wilson wants to merge 1 commit into
Conversation
The repo only had release.yml, so npm test never ran on a pull request. This runs npm ci, npm test and npm run build on every pull request and on pushes to main, on the same Node version and pinned actions as the release workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
💬 Discussion in Slack: #pr-review-node-sdk-v2-52-ci-run-the-tests-and-build-on-pull-requests Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Low impact] The PR appears safe to merge.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The repo's only workflow is
release.yml, sonpm testnever runs on a pull request. As of #51,npm testalso type-checks the tests, but that only helps if something runs it. Requested by Saif in #51 (comment).This adds
.github/workflows/test.yml, which runsnpm ci,npm testandnpm run buildon every pull request and on pushes tomain. It uses the same pinnedactions/checkoutandactions/setup-nodecommits and the same Node version (24.14.0) asrelease.yml, withcontents: readpermissions.Steps to verify the change
main:npm ci,npm test(174 tests) andnpm run buildall pass.🤖 Generated with Claude Code