Skip to content

ci: run the tests and build on pull requests - #52

Closed
scott-ray-wilson wants to merge 1 commit into
mainfrom
scott/run-tests-on-prs
Closed

scott-ray-wilson wants to merge 1 commit into
mainfrom
scott/run-tests-on-prs

Conversation

@scott-ray-wilson

Copy link
Copy Markdown
Contributor

Context

The repo's only workflow is release.yml, so npm test never runs on a pull request. As of #51, npm test also type-checks the tests, but that only helps if something runs it. Requested by Saif in #51 (comment).

This adds .github/workflows/test.yml, which runs npm ci, npm test and npm run build on every pull request and on pushes to main. It uses the same pinned actions/checkout and actions/setup-node commits and the same Node version (24.14.0) as release.yml, with contents: read permissions.

Steps to verify the change

  • The workflow runs on this pull request.
  • Locally, on main: npm ci, npm test (174 tests) and npm run build all pass.

🤖 Generated with Claude Code

The repo only had release.yml, so npm test never ran on a pull request. This
runs npm ci, npm test and npm run build on every pull request and on pushes to
main, on the same Node version and pinned actions as the release workflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-node-sdk-v2-52-ci-run-the-tests-and-build-on-pull-requests

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Low impact] The PR appears safe to merge.

Summary

Adds .github/workflows/test.yml to check pull requests and pushes to main.

  • Pull requests and pushes to main now run tests and a build.

Reviews (1) · Last reviewed commit: "ci: run the tests and build on pull requ..." · Reviewed by Greptile

@scott-ray-wilson
scott-ray-wilson deleted the scott/run-tests-on-prs branch November 13, 2026 00:45
@scott-ray-wilson

Copy link
Copy Markdown
Contributor Author

Folded into #51 (commit 5413e9c) instead of a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant