Skip to content

feat(agent-vault): add --metadata to run and sessions create - #506

Merged
saifsmailbox98 merged 3 commits into
mainfrom
saif/age2-320-support-attaching-custom-metadata-to-sessions
Nov 17, 2026
Merged

saifsmailbox98 merged 3 commits into
mainfrom
saif/age2-320-support-attaching-custom-metadata-to-sessions

Conversation

@saifsmailbox98

@saifsmailbox98 saifsmailbox98 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Description 📣

Adds a repeatable --metadata key=value flag to infisical agent-vault run and infisical agent-vault sessions create, to attach custom metadata to the session the command creates. Resolves AGE2-320.

  • Splits on the first =, so --metadata url=https://x?a=b keeps the whole value (a key can't contain =). A pair without =, an empty value (--metadata flag=) or a key given twice is refused before the request, as a structured error with -o json|yaml
  • Refused on run together with --session-token, same as --label
  • sessions create -o json|yaml prints metadata as a map ({"runId":"8812"}), {} when there is none. The default token-only output is unchanged
  • sessions create telemetry gets hasMetadata next to labeled

Infisical PR: Infisical/infisical#9553

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

  • New or changed commands follow CLI.md, and new commands and flags are recorded in packages/cmd/testdata/command_surface.json
  • Updated AGENTS.md files (if needed)
  • I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-506-feat-agent-vault-add-metadata-to-run-and-sessions-create

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 16, 2026

Copy link
Copy Markdown

AGE2-320

@veria-ai

veria-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Adds repeatable --metadata key=value flags to agent-vault run and agent-vault sessions create.

  • Agent Vault commands now attach custom metadata to new sessions.
  • Session details show metadata in JSON and YAML output.

Code review only; tests were not run.

Reviews (3) · Last reviewed commit: "fix(agent-vault): refuse an empty --meta..." · Reviewed by Greptile

Comment thread packages/cmd/agent_vault_run.go Resolved
Comment thread packages/cmd/agent_vault_run.go Resolved

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saifsmailbox98
saifsmailbox98 merged commit 6fa75a9 into main Nov 17, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants