Repository navigation
fix(rdp): bump Go to 1.26.11 and strip LLVM bitcode from the bridge - #502
Merged
Merged
Conversation
- Updated Go version in go.mod and various workflow files to 1.26.11. - Added github.com/alessio/shellescape v1.4.1 as a direct dependency in go.mod.
- Introduced a new script `strip-llvm-bitcode.sh` to remove LLVM bitcode from the RDP bridge library, addressing linking issues with Go 1.26.11. - Updated the GitHub Actions workflow to include a step for running the new script after building the Rust RDP bridge. - Modified the README to document the new stripping step and its necessity for successful builds. - Added `llvm-tools` to the Rust toolchain components for compatibility with the new script.
|
💬 Discussion in Slack: #pr-review-cli-502-fix-rdp-bump-go-to-1-26-11-and-strip-llvm-bitcode-from-the-bri Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
Contributor
Contributor
[Medium impact] This PR appears safe to merge.
|
- Introduced a new job in the GitHub Actions workflow to build the RDP bridge on macOS. - Added steps for setting up Go, caching cargo registry and target, installing the Rust toolchain, building the Rust RDP bridge, stripping LLVM bitcode, and running the CLI. - This enhancement ensures compatibility and successful builds on macOS environments.
- Added read permissions for contents in the GitHub Actions workflow configuration. - This change enhances security and ensures the workflow has the necessary access to repository contents during execution.
lb-vn
reviewed
Nov 12, 2026
lb-vn
left a comment
Member
There was a problem hiding this comment.
e2e/README.md still goes straight from cargo build --release to go build -tags rdp for the rdp tests, so following it fails on mac/linux now. we should add the strip step there too.
- Removed direct dependency on github.com/alessio/shellescape v1.4.1 and added it as an indirect dependency. - Updated e2e/README.md to clarify the steps for building the Rust RDP bridge, including the new requirement to strip LLVM bitcode.
lb-vn
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Go 1.26.11 (CVE-2026-97038) refuses to link a library when a
#cgo LDFLAGS-Ldirectory contains objects with LLVM bitcode sections. The RDP bridge’s directive points attarget/release, and Rust’s precompiled standard library ships with that bitcode embedded, socargo build --releasefollowed bygo build -tags rdpfails on macOS and Linux.This bumps the toolchain to 1.26.11 in
go.mod,e2e/go.mod, and the GitHub workflows, and addspackages/pam/handlers/rdp/native/strip-llvm-bitcode.sh. The script uses the Rust toolchain’sllvm-objcopy(llvm-toolsis now inrust-toolchain.toml) to drop.llvmbc,.llvmcmd,__LLVM,__bitcode, and__LLVM,__cmdlinefromlibinfisical_rdp_bridge.aand Cargo’s copy underdeps/. The linker does not read those sections, so the linked code is unchanged. The e2e RDP job runs the script aftercargo build --release. Cross and release builds that pass the per-target directory throughCGO_LDFLAGSare not scanned by Go and do not need it. Do not run it on a Windows COFF archive; Go 1.26.11 rejects the stripped result.github.com/alessio/shellescapeis listed as a direct requirement ingo.mod. This branch does not add an import of it.Type ✨
packages/cmd/testdata/command_surface.json