Skip to content

fix(util): qualify Homebrew tap installs in the update hint - #501

Merged
victorvhs017 merged 2 commits into
mainfrom
chore/fix-update-hint
Nov 13, 2026
Merged

victorvhs017 merged 2 commits into
mainfrom
chore/fix-update-hint

Conversation

@victorvhs017

@victorvhs017 victorvhs017 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description 📣

The update notice always told Homebrew users to run brew upgrade infisical. Homebrew skips a formula from a tap the user has not trusted when it is named by its short name, and only acts on it when the name is fully qualified (<tap>/infisical). Anyone who installed from a tap such as infisical/get-cli was given a command Homebrew would not run.

On darwin, when the binary path is under Homebrew or Cellar, the hint now reads source.tap from the keg receipt at Cellar/infisical/<version>/INSTALL_RECEIPT.json (two directories above the executable) and prints brew update && brew upgrade <tap>/infisical. A missing, unreadable, or invalid receipt, an empty tap, homebrew/core, or a tap string outside owner/name still prints brew upgrade infisical.

Also added a vuln check fix

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

On a Mac with a Cellar install, open $(brew --prefix)/Cellar/infisical/*/INSTALL_RECEIPT.json and confirm source.tap. The next update notice should print brew upgrade <that-tap>/infisical when the tap is not homebrew/core.


  • New or changed commands follow CLI.md, and new commands and flags are recorded in packages/cmd/testdata/command_surface.json
  • Updated AGENTS.md files (if needed)
  • I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

…NSTALL_RECEIPT.json

- Introduced a new function to determine the full Homebrew formula name based on the tap specified in the INSTALL_RECEIPT.json file.
- Updated the getUpdateInstructions function to return the correct update command for Homebrew based on the formula name.
- Added unit tests to validate the behavior of the new update instructions based on various receipt scenarios.
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-501-fix-util-qualify-homebrew-tap-installs-in-the-update-hint

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@veria-ai

veria-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable issue was established.

Summary

The PR uses Homebrew receipts to name tapped formulas in update hints and raises the Go version to 1.26.11.

  • Homebrew update notices name the installed tap’s formula.
  • Local RDP builds strip embedded LLVM bitcode before Go links the bridge.
  • The module lists shellescape as a direct requirement.

Reviews (4) · Last reviewed commit: "feat(rdp): add script to strip LLVM bitc..." · Reviewed by Greptile

Comment thread packages/util/check-for-update_test.go Resolved
- Updated the test for getUpdateInstructions to use filepath.ToSlash for consistent file path formatting on macOS.
- Ensured that the test accurately reflects the expected output for Homebrew update commands.
@victorvhs017
victorvhs017 merged commit ae79a1e into main Nov 13, 2026
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants