Repository navigation
fix(util): qualify Homebrew tap installs in the update hint - #501
Merged
Merged
Conversation
…NSTALL_RECEIPT.json - Introduced a new function to determine the full Homebrew formula name based on the tap specified in the INSTALL_RECEIPT.json file. - Updated the getUpdateInstructions function to return the correct update command for Homebrew based on the formula name. - Added unit tests to validate the behavior of the new update instructions based on various receipt scenarios.
|
💬 Discussion in Slack: #pr-review-cli-501-fix-util-qualify-homebrew-tap-installs-in-the-update-hint Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
Contributor
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issue was established.
|
- Updated the test for getUpdateInstructions to use filepath.ToSlash for consistent file path formatting on macOS. - Ensured that the test accurately reflects the expected output for Homebrew update commands.
victorvhs017
force-pushed
the
chore/fix-update-hint
branch
from
November 12, 2026 14:25
8e29aad to
a427612
Compare
Thiago-AS
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
The update notice always told Homebrew users to run
brew upgrade infisical. Homebrew skips a formula from a tap the user has not trusted when it is named by its short name, and only acts on it when the name is fully qualified (<tap>/infisical). Anyone who installed from a tap such asinfisical/get-cliwas given a command Homebrew would not run.On darwin, when the binary path is under Homebrew or Cellar, the hint now reads
source.tapfrom the keg receipt atCellar/infisical/<version>/INSTALL_RECEIPT.json(two directories above the executable) and printsbrew update && brew upgrade <tap>/infisical. A missing, unreadable, or invalid receipt, an empty tap,homebrew/core, or a tap string outsideowner/namestill printsbrew upgrade infisical.Also added a vuln check fix
Type ✨
Tests 🛠️
On a Mac with a Cellar install, open
$(brew --prefix)/Cellar/infisical/*/INSTALL_RECEIPT.jsonand confirmsource.tap. The next update notice should printbrew upgrade <that-tap>/infisicalwhen the tap is nothomebrew/core.packages/cmd/testdata/command_surface.json