Repository navigation
feat(pam): output masking - #499
Conversation
|
💬 Discussion in Slack: #pr-review-cli-499-feat-pam-output-masking Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
PR overviewThe PR adds output masking for PAM sessions, including a credit-card masking preset for output sent to PostgreSQL and SSH clients. Nine issues have been addressed, with one masking gap still open. The credit-card preset misses valid 14-digit and 19-digit card numbers, allowing them to reach clients unchanged even when credit-card masking is enabled. This leaves a bounded sensitive-data exposure risk for sessions whose output contains those card lengths. Open issues (1)
Fixed/addressed: 9 · PR risk: 5/10 Reviews |
[Medium impact] The PR appears safe to merge within its stated best-effort scope.
|
|
@greptile re-review |
Description 📣
Adds output masking for postgres and SSH. Supporting PR for Infisical/infisical#9403
Output masking hides values from accidental exposure, such as reads by an AI agent. It isn't a boundary against a user who deliberately transforms data before reading it, so bypasses of that kind are out of scope.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippetspackages/cmd/testdata/command_surface.json