Skip to content

feat(pam): session recording test for postgres and rdp - #497

Merged
lb-vn merged 4 commits into
mainfrom
PAM-549
Nov 13, 2026
Merged

lb-vn merged 4 commits into
mainfrom
PAM-549

Conversation

@lb-vn

@lb-vn lb-vn commented Nov 11, 2026

Copy link
Copy Markdown
Member

Description 📣

Session recording test for postgres and rdp

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

  • New or changed commands follow CLI.md, and new commands and flags are recorded in packages/cmd/testdata/command_surface.json
  • Updated AGENTS.md files (if needed)
  • I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

@lb-vn
lb-vn requested a review from bernie-g November 11, 2026 01:44
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-497-feat-pam-session-recording-test-for-postgres-and-rdp

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 11, 2026

Copy link
Copy Markdown

PAM-549

@veria-ai

veria-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Low impact] The PR appears safe to merge; no new actionable issues remain.

Summary

Adds end-to-end checks for PostgreSQL and RDP session recordings.

  • PostgreSQL tests recover recorded queries after interruptions.
  • RDP tests check that playback contains frames from the target.

Earlier findings are addressed or retracted. lb-vn accepted the fixed-port collision risk because Ryuk cleans up normal runs and changing the port each run would defeat stack reuse.

Reviews (4) · Last reviewed commit: "address grep comments" · Reviewed by Greptile

Comment thread e2e/packages/infisical/compose.go Resolved
Comment thread e2e/pam/postgres_test.go Resolved
Comment thread e2e/pam/pam_helpers.go Resolved
Comment thread e2e/pam/pam_helpers.go Resolved
Comment thread e2e/pam/pam_helpers.go Resolved
@lb-vn
lb-vn merged commit 6f84ca3 into main Nov 13, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants