Repository navigation
Sheet: two-pane SheetAside on a Panes primitive; switch rows follow the field measure - #95
Open
andrewhuhh wants to merge 16 commits into
Open
andrewhuhh wants to merge 16 commits into
andrewhuhh wants to merge 16 commits into
Conversation
…elds' measure Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-95-sheet-two-pane-sheetaside-on-a-panes-primitive-switch-rows-f Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The changes affect shared UI components and the sheet workflow. Add scrolling for standalone Findings
|
…cap counts only vertical fields and spares wide rows Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ls as a page Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… state across widths Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…tViews and SheetSections Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Merged
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A two-pane sheet modelled on the current product's PAM account sheet (INF-176), built on one layout primitive, plus a fix so switch rows follow the field width rule.
Panes (
ui/layout). A fixed-width aside beside a main pane inside a bounded height. The aside declares an identity (media, title, description, badges) and a body. Each pane scrolls on its own, and the main pane sets--cipher-size-measure-field: 100%so its fields run the pane's full width. The aside issize-pane-aside(320px), long values wrap inside it, and a DataList in it stacks each term above its value.Narrow layout. Below
size-pane-collapse(720px, measured on the Panes itself with a ResizeObserver), the aside no longer sits beside the main pane. Its identity becomes the fixed header (icon, title, description, badges, nothing else). It caps at 40% of the height and scrolls on its own if it runs long. Tabs sit on the header's single bottom rule, the same shape as tabs on the header, and the aside body is always the first tab. With controlled header Tabs, Details comes first and the sheet's own tabs follow. Without header tabs, there are two tabs: Details, then the main pane undermainLabel. The sheet opens on the tab the wide layout shows, never on Details. The main pane renders the same tree at both widths, so edits survive a resize. Consumers write the same markup for both layouts, and Panes outside a sheet behaves the same.SheetAside and
size="xl".SheetAsideis a direct child ofSheetContentand takesmedia,title,description,badgesand the body as children, pluslabel(the aside tab, default Details) andmainLabel.mainLabelis required because SheetAside cannot see whether the header has tabs. It is used only when the header has none, and the docs say so. It splits the sheet into Panes, and everything else (header with thetabsslot, body, footer, a form around them, orSheetViews) becomes the main pane with the usual pinned head and foot.size-sheet-xlis 1024px, leaving 704px for the main pane. The header band, tabs on the header rule and the close button are unchanged, and a main pane with no header clears the close button.Switch rows among fields. A
Switch layout="row"or a horizontalFieldamong vertical fields takes the samesize-measure-fieldcap, so the switch ends at the inputs' right edge. A rows-only card keeps full-width rows.Docs. The Sheet example "Two panes: an aside beside tabs" has a default, a long-values and a no-tabs account, plus a Switch example "A row among fields".
Narrow renders are at a 600px viewport; wide ones at 1706x971.