Skip to content

Sheet: two-pane SheetAside on a Panes primitive; switch rows follow the field measure - #95

Open
andrewhuhh wants to merge 16 commits into
mainfrom
andrew/two-pane-sheet
Open

andrewhuhh wants to merge 16 commits into
mainfrom
andrew/two-pane-sheet

Conversation

@andrewhuhh

@andrewhuhh andrewhuhh commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

A two-pane sheet modelled on the current product's PAM account sheet (INF-176), built on one layout primitive, plus a fix so switch rows follow the field width rule.

Panes (ui/layout). A fixed-width aside beside a main pane inside a bounded height. The aside declares an identity (media, title, description, badges) and a body. Each pane scrolls on its own, and the main pane sets --cipher-size-measure-field: 100% so its fields run the pane's full width. The aside is size-pane-aside (320px), long values wrap inside it, and a DataList in it stacks each term above its value.

Narrow layout. Below size-pane-collapse (720px, measured on the Panes itself with a ResizeObserver), the aside no longer sits beside the main pane. Its identity becomes the fixed header (icon, title, description, badges, nothing else). It caps at 40% of the height and scrolls on its own if it runs long. Tabs sit on the header's single bottom rule, the same shape as tabs on the header, and the aside body is always the first tab. With controlled header Tabs, Details comes first and the sheet's own tabs follow. Without header tabs, there are two tabs: Details, then the main pane under mainLabel. The sheet opens on the tab the wide layout shows, never on Details. The main pane renders the same tree at both widths, so edits survive a resize. Consumers write the same markup for both layouts, and Panes outside a sheet behaves the same.

SheetAside and size="xl". SheetAside is a direct child of SheetContent and takes media, title, description, badges and the body as children, plus label (the aside tab, default Details) and mainLabel. mainLabel is required because SheetAside cannot see whether the header has tabs. It is used only when the header has none, and the docs say so. It splits the sheet into Panes, and everything else (header with the tabs slot, body, footer, a form around them, or SheetViews) becomes the main pane with the usual pinned head and foot. size-sheet-xl is 1024px, leaving 704px for the main pane. The header band, tabs on the header rule and the close button are unchanged, and a main pane with no header clears the close button.

Switch rows among fields. A Switch layout="row" or a horizontal Field among vertical fields takes the same size-measure-field cap, so the switch ends at the inputs' right edge. A rows-only card keeps full-width rows.

Docs. The Sheet example "Two panes: an aside beside tabs" has a default, a long-values and a no-tabs account, plus a Switch example "A row among fields".

Narrow renders are at a 600px viewport; wide ones at 1706x971.

State Light Dark
Wide, default
Wide, long values
Wide, no header tabs
Narrow, default (opens on Configuration)
Narrow, Details tab
Narrow, long values
Narrow, no header tabs (Details, Configuration)
Narrow, no header tabs, Details tab

Open in Capy

…elds' measure

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-95-sheet-two-pane-sheetaside-on-a-panes-primitive-switch-rows-f

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5 Tier: plus

[Medium impact] The changes affect shared UI components and the sheet workflow.

Add scrolling for standalone Panes before merging; the nested-header tab issue is non-blocking.

Findings

  1. P1 Standalone main content cannot scroll ▶
  2. P2 Nested headers gain extra tabs ▶

Summary

Adds responsive two-pane sheets through SheetAside and the shared Panes component.

  • A bounded layout can show an aside beside a main pane.

Reviews (9) · Last reviewed commit: "Merge main into andrew/two-pane-sheet" · Reviewed by Greptile

Comment thread src/ui/panes.module.css Resolved
Comment thread src/ui/helpers.module.css Resolved
Comment thread src/ui/helpers.module.css Resolved
Comment thread src/ui/panes.module.css Resolved
andrewhuhh and others added 3 commits November 16, 2026 21:43
…cap counts only vertical fields and spares wide rows

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ls as a page

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Comment thread src/ui/layout.tsx Resolved
Comment thread src/ui/panes.module.css Resolved
Comment thread src/ui/sheet.tsx Resolved
andrewhuhh and others added 2 commits November 16, 2026 22:43
… state across widths

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Comment thread src/ui/layout.tsx Resolved
Comment thread src/ui/sheet.tsx Resolved
andrewhuhh and others added 2 commits November 16, 2026 22:56
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Comment thread src/base.css Resolved
andrewhuhh and others added 2 commits November 16, 2026 23:17
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Comment thread src/ui/layout.tsx Resolved
Comment thread src/ui/sheet.tsx Resolved
andrewhuhh and others added 3 commits November 17, 2026 02:07
…tViews and SheetSections

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@andrewhuhh andrewhuhh mentioned this pull request Nov 17, 2026
andrewhuhh and others added 3 commits November 17, 2026 03:36
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant