Repository navigation
Apply the parked style calls, and keep ListRow text inside its frame - #124
Open
andrewhuhh wants to merge 3 commits into
Open
andrewhuhh wants to merge 3 commits into
andrewhuhh wants to merge 3 commits into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-124-apply-the-parked-style-calls-and-keep-listrow-text-inside-i Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge.
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies three of the four parked style calls Andrew approved. It also keeps ListRow text inside its frame when a description holds content that doesn't wrap.
Parked style calls
commitprop doc now says why: a half-picked range never reaches the value.Each table shows three states, from top to bottom: data-poor, optimal, and stressed (long names, keys and paths).
DataTable group rows
Soft badge
Mobile theme picker (TopBar account sheet at 390px; data states don't apply)
ListRow keeps long keys and paths inside its frame
ListRow's text column is a grid with an implicit
autotrack. A description holding nowrap content, such as an environment followed by a truncating path, sized that track to the content's full width. Both the title and the description then ran past the row's edge..listBodynow setsgrid-template-columns: minmax(0, 1fr)and.descriptionsetsmin-width: 0, so the title truncates and the path ellipsizes. In a 340px frame, two of six rows overflowed before the fix and none do after. Consumers no longer need thewidth: 0; min-width: 100%workaround.The List showcase gains a "Long keys and paths" example:
Baselines
58 baselines change, and each one is an example that renders a soft badge (Light and Dark) or a grouped DataTable (Dark only). The 4
list-long-keysbaselines are new. A full--update-snapshots=allrun also rewrotetile-picker-links,tile-picker-stressedandprogress-defaultwith a few anti-aliasing pixels; those aren't part of this change and were reverted.