Skip to content

Apply the parked style calls, and keep ListRow text inside its frame - #124

Open
andrewhuhh wants to merge 3 commits into
mainfrom
andrew/parked-style-calls
Open

andrewhuhh wants to merge 3 commits into
mainfrom
andrew/parked-style-calls

Conversation

@andrewhuhh

Copy link
Copy Markdown
Collaborator

Applies three of the four parked style calls Andrew approved. It also keeps ListRow text inside its frame when a description holds content that doesn't wrap.

Parked style calls

  • Group rows in a Dark DataTable use the header's tint. They now read as sub-headers, distinct from data rows. Light is unchanged.
  • Soft badges have a paper fill with a line-soft border. In Light the old line-soft fill was heavy and sat close to warn. Dark barely changes.
  • The mobile theme picker shows an icon and a label on each segment (monitor, sun, moon), using the same icons as the desktop TopBar, and keeps full-width touch targets.
  • DateRangePicker keeps its current default: Apply with presets or two months, and immediate commit otherwise. There's no behaviour change. The commit prop doc now says why: a half-picked range never reaches the value.

Each table shows three states, from top to bottom: data-poor, optimal, and stressed (long names, keys and paths).

DataTable group rows

Light Dark
Desktop
390px

Soft badge

Light Dark
Desktop
390px

Mobile theme picker (TopBar account sheet at 390px; data states don't apply)

Light Dark

ListRow keeps long keys and paths inside its frame

ListRow's text column is a grid with an implicit auto track. A description holding nowrap content, such as an environment followed by a truncating path, sized that track to the content's full width. Both the title and the description then ran past the row's edge. .listBody now sets grid-template-columns: minmax(0, 1fr) and .description sets min-width: 0, so the title truncates and the path ellipsizes. In a 340px frame, two of six rows overflowed before the fix and none do after. Consumers no longer need the width: 0; min-width: 100% workaround.

The List showcase gains a "Long keys and paths" example:

Light Dark
Desktop
390px

Baselines

58 baselines change, and each one is an example that renders a soft badge (Light and Dark) or a grouped DataTable (Dark only). The 4 list-long-keys baselines are new. A full --update-snapshots=all run also rewrote tile-picker-links, tile-picker-stressed and progress-default with a few anti-aliasing pixels; those aren't part of this change and were reverted.

Open in Capy

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-124-apply-the-parked-style-calls-and-keep-listrow-text-inside-i

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge.

Summary

This PR updates table group colors, soft badges, and mobile theme choices, and keeps long ListRow text inside its frame.

  • Long ListRow titles and paths stay inside the row’s frame.
  • Dark grouped table rows use the header’s tint.
  • Soft badges use a paper fill with a soft border.
  • The mobile theme picker shows an icon beside each label.
  • The DateRangePicker comment explains why its default keeps half-picked ranges out of the value.

No new actionable issues found.

Reviews (2) · Last reviewed commit: "Set the group row ground per scope" · Reviewed by Greptile

Comment thread src/ui/data.module.css Resolved
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant