Repository navigation
Rework SortableGrid dragging, and make framed list content flush - #122
Open
andrewhuhh wants to merge 3 commits into
Open
andrewhuhh wants to merge 3 commits into
andrewhuhh wants to merge 3 commits into
Conversation
…ent flush in framed cards Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-122-rework-sortablegrid-dragging-and-make-framed-list-content-f Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The reviewed changes appear safe to merge after the release timing stated in the PR.
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks SortableGrid's pointer drag so a card follows the pointer and the grid only reshuffles when the drop target actually changes. Also makes list content flush inside two framed-card examples.
SortableGrid drag
spring.moderate), or snaps under reduced motion. Keyboard reordering is unchanged.Reorder count
Measured with a Playwright spec: a slow 160-step drag of the "Secrets Management" handle to the third card plus a small jiggle, counting changes to the DOM order of the cards over the whole drag.
The final order is the same on every run. A separate check with reduced motion and the keyboard (Space, ArrowRight, ArrowDown, Space) moves the card to the end and keeps focus on its handle.
Re-check on main after v0.1.14
Repeated on 198ba3d (main after the release, merged in) with the same slow drag to the third slot. Each run reorders twice, lands on the same final order, and the held card sits exactly under the pointer while dragging (0px offset).
Recordings
Before:
https://api.capy.ai/pr-assets/v_PPrUQCBiL0u6RWgUNgMKluKxBY5hVQ39BSV6q5DJTuY.mp4
After:
https://api.capy.ai/pr-assets/v_oxBva_hYBuzxou3dPpauE12YuKymbHK8SrSCg5F5quQ.mp4
Mid-drag, with the placeholder:
The
sortable-grid-defaultbaselines don't change: the resting state is identical.Flush content in framed cards
Framed card content was padded with
Insetaround a single borderless child, which left a gap between the card edge and the rows.sortable-list/card("Evaluation order") andempty-state/ghost("App connections") now useflush. An audit of every showcase example and every Cipher component found no other cases.These are the 8 baseline changes: