Repository navigation
Fix two-pane Sheet collapse, identity, aside truncation and initial focus - #120
Merged
Merged
Conversation
…ocus Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-120-fix-two-pane-sheet-collapse-identity-aside-truncation-and-i Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge; no actionable defects were found.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four problems INFS-1118 found while adopting the 0.1.13 two-pane Sheet (#95) on the PAM sheets in infisical#9623.
Changes
size-pane-collapsegoes from 720px to 880px, which is the 320px aside plus a 560px main pane. A 768px sheet (3/4 of a 1024px viewport) used to split, which left the main pane about 448px wide and truncated tables. It now uses the Details tab layout. A 960px sheet (1280px viewport) still splits.flex: 0 1 auto, so a tall main pane squeezed it, cutting off the title and hiding the badges. It's nowflex: noneand keeps its 40% cap with its own scroll.align-items: flex-start, so a value sized to its content and MiddleTruncate had no width to measure. Rows now stretch, and text still starts at the left.focusFirstControltakes an optional selector to prefer. A sheet with a SheetAside preferssheet-main, so a link in the aside (such as Template) no longer takes the first focus. If the main pane has nothing focusable, it falls back to the whole sheet.In the two-pane example, the aside's Host is now a MiddleTruncate and Template is a link, so the example covers fixes 3 and 4.
Renders
These are the "Long values" sheet at a 971px height, after the change unless marked before. The optimal-data sheet at every width, both themes, and the Details tab are in renders/INFS-835/two-pane-sheet/ in the Captain's drive.
Visual gate
All 410 tests pass and no baselines change, because the showcase renders sheets closed. The renders above come from a throwaway spec that opens the sheet at each width, which isn't committed.