Skip to content

Fix two-pane Sheet collapse, identity, aside truncation and initial focus - #120

Merged
andrewhuhh merged 1 commit into
mainfrom
andrew/two-pane-sheet-fixes
Nov 17, 2026
Merged

andrewhuhh merged 1 commit into
mainfrom
andrew/two-pane-sheet-fixes

Conversation

@andrewhuhh

Copy link
Copy Markdown
Collaborator

Fixes four problems INFS-1118 found while adopting the 0.1.13 two-pane Sheet (#95) on the PAM sheets in infisical#9623.

Changes

  1. An xl sheet on a 1024px viewport now collapses. size-pane-collapse goes from 720px to 880px, which is the 320px aside plus a 560px main pane. A 768px sheet (3/4 of a 1024px viewport) used to split, which left the main pane about 448px wide and truncated tables. It now uses the Details tab layout. A 960px sheet (1280px viewport) still splits.
  2. The narrow identity block no longer shrinks. It was flex: 0 1 auto, so a tall main pane squeezed it, cutting off the title and hiding the badges. It's now flex: none and keeps its 40% cap with its own scroll.
  3. MiddleTruncate works in an aside DataList. The aside's stacked rows used align-items: flex-start, so a value sized to its content and MiddleTruncate had no width to measure. Rows now stretch, and text still starts at the left.
  4. Opening the sheet focuses the main pane. focusFirstControl takes an optional selector to prefer. A sheet with a SheetAside prefers sheet-main, so a link in the aside (such as Template) no longer takes the first focus. If the main pane has nothing focusable, it falls back to the whole sheet.

In the two-pane example, the aside's Host is now a MiddleTruncate and Template is a link, so the example covers fixes 3 and 4.

Renders

These are the "Long values" sheet at a 971px height, after the change unless marked before. The optimal-data sheet at every width, both themes, and the Details tab are in renders/INFS-835/two-pane-sheet/ in the Captain's drive.

Width Light Dark
768
1024
1280
1024, before (split, about 448px main pane) 1024, after, Details tab
1280, before (Host overflows the aside) 1280, after (Host truncates in the middle)

Visual gate

All 410 tests pass and no baselines change, because the showcase renders sheets closed. The renders above come from a throwaway spec that opens the sheet at each width, which isn't committed.

Open in Capy

…ocus

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-120-fix-two-pane-sheet-collapse-identity-aside-truncation-and-i

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Fixes two-pane Sheet sizing, truncation, and opening focus.

  • Narrow Sheets switch to tabs before their main pane gets cramped.
  • Long values fit inside the Sheet aside instead of overflowing.
  • Sheets with an aside focus the main pane when they open.

No actionable issues were found. Runtime tests and visual checks were not run because dependencies are not installed.

Author acknowledgment: andrewhuhh notes that existing screenshots keep sheets closed. The open-sheet checks were throwaway tests and were not committed.

Reviews (1) · Last reviewed commit: "Fix two-pane Sheet collapse, identity, a..." · Reviewed by Greptile

@andrewhuhh
andrewhuhh merged commit 5e843d9 into main Nov 17, 2026
9 checks passed
@andrewhuhh andrewhuhh mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant