Repository navigation
Item: button labels count as visible text again - #114
Open
andrewhuhh wants to merge 1 commit into
Open
andrewhuhh wants to merge 1 commit into
andrewhuhh wants to merge 1 commit into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-114-item-button-labels-count-as-visible-text-again Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] This PR appears safe to merge.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a v0.1.12 regression from #108, found by the new visual gate's first run against v0.1.10.
#108 made the Button label span
display: contents. Item decides whether its actions are icon-only by walking up from each text node and treating any ancestor narrower than 2px as hidden. Adisplay: contentselement has no box, so itsoffsetWidthis 0, and every text button looked hidden. Item then treated rows with text buttons as icon-only and put the buttons beside the copy instead of on their own row below 36rem. The title wrapped into a narrow column, against the example's own caption ("buttons on their own row at the copy edge").hasVisibleTextnow walks throughdisplay: contentsancestors. The gate's item, sortable-list, header-search and card pages now match v0.1.10 for every Item example. The only differences left are the framed card-head icons that #106 fixed on purpose.