Skip to content

Card: framed header action children keep their own display - #113

Merged
andrewhuhh merged 1 commit into
mainfrom
andrew/card-action-children
Nov 17, 2026
Merged

andrewhuhh merged 1 commit into
mainfrom
andrew/card-action-children

Conversation

@andrewhuhh

Copy link
Copy Markdown
Collaborator

Fixes a v0.1.12 regression from #108, reported by the license server. #108 put display: block and min-width: 0 in a selector list that also matched .cardAction > :not([data-cipher-button]). As a result, every non-button child of a framed card head action became a block: an Inline wrapper, a Select, a Badge, a Switch, a ToggleGroup, a HeaderSearch. A Select trigger grew to 48px and wrapped its chevron below its value. A Badge truncated to "C…", and the Button beside them shrank to "+ A".

The rule now splits in two:

  • Non-button direct children of a framed card action get the v0.1.10 rule back (overflow hidden, ellipsis, nowrap) and keep their own display.
  • display: block and min-width: 0 apply only to [data-slot="button-text"] inside a non-trigger Button, which keeps Card: framed header actions keep their icon inline #106's fix: the icon stays inline and only the label truncates.

Audit

I rendered 12 framed card head action compositions on v0.1.10, v0.1.12 and this branch, at three columns and at 340px cards, in Light and Dark. The compositions are a single button, an icon button, a dropdown trigger, an Inline group, Select plus Badge plus Button, HeaderSearch plus Button, a Switch, badges, a long label, an Inline with a long label, a Tooltip-wrapped button and a ToggleGroup. They come from the card band-actions example and the action props on the app's v4 pages, where Button, Inline, Switch, Badge, dropdown menus and ToggleGroup appear. Measured in the browser:

Composition v0.1.10 v0.1.12 This PR
Button, icon button, dropdown trigger 28px, inline same same
Inline group flex, 28px block flex, 28px
Select + Badge + Button Select flex 28px, Button 42px (icon stacked, the #92 bug) Select block 48px, wraps out of the band; Badge block Select flex 28px, Badge flex, Button 28px
HeaderSearch + Button search flex, Button 42px (stacked) search block search flex, Button 28px
Switch, badges, ToggleGroup flex block flex
Long label, Tooltip-wrapped button 42px, icon stacked 28px, label truncates 28px, label truncates

Every non-button child is back to its v0.1.10 display and size. Every button keeps the 0.1.11 fix (28px, icon inline). The 40px header band holds in every case except one.

That exception is an Inline holding a badge and a very long button label: Inline wraps by default, so it grows to two lines (56px). v0.1.10 does the same, at 70px, and pass wrap={false} on the Inline to keep it on one line. At 340px, Select plus Badge plus Button squeezes the badge and button, as it did in v0.1.10.

v0.1.10 v0.1.12 This PR
Three columns, Light v0.1.10 v0.1.12 this PR
Three columns, Dark v0.1.10 v0.1.12 this PR
340px cards, Light v0.1.10 v0.1.12 this PR
340px cards, Dark v0.1.10 v0.1.12 this PR

Open in Capy

…en keep their display

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai capy-ai Bot added the live-preview label Nov 17, 2026
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-113-card-framed-header-action-children-keep-their-own-display

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Low impact] This PR appears safe to merge; no actionable issues were found.

Summary

Splits the framed-card action styles so non-button children keep their own display while button labels retain their truncation styles.

  • Framed card actions keep controls in their own layouts.

Reviews (1) · Last reviewed commit: "Card: framed header actions only block t..." · Reviewed by Greptile

@andrewhuhh
andrewhuhh merged commit fe462a2 into main Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant