Repository navigation
Card: framed header action children keep their own display - #113
Merged
Merged
Conversation
…en keep their display Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-113-card-framed-header-action-children-keep-their-own-display Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Low impact] This PR appears safe to merge; no actionable issues were found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a v0.1.12 regression from #108, reported by the license server. #108 put
display: blockandmin-width: 0in a selector list that also matched.cardAction > :not([data-cipher-button]). As a result, every non-button child of a framed card head action became a block: an Inline wrapper, a Select, a Badge, a Switch, a ToggleGroup, a HeaderSearch. A Select trigger grew to 48px and wrapped its chevron below its value. A Badge truncated to "C…", and the Button beside them shrank to "+ A".The rule now splits in two:
display: blockandmin-width: 0apply only to[data-slot="button-text"]inside a non-trigger Button, which keeps Card: framed header actions keep their icon inline #106's fix: the icon stays inline and only the label truncates.Audit
I rendered 12 framed card head action compositions on v0.1.10, v0.1.12 and this branch, at three columns and at 340px cards, in Light and Dark. The compositions are a single button, an icon button, a dropdown trigger, an Inline group, Select plus Badge plus Button, HeaderSearch plus Button, a Switch, badges, a long label, an Inline with a long label, a Tooltip-wrapped button and a ToggleGroup. They come from the card band-actions example and the
actionprops on the app's v4 pages, where Button, Inline, Switch, Badge, dropdown menus and ToggleGroup appear. Measured in the browser:Every non-button child is back to its v0.1.10 display and size. Every button keeps the 0.1.11 fix (28px, icon inline). The 40px header band holds in every case except one.
That exception is an Inline holding a badge and a very long button label: Inline wraps by default, so it grows to two lines (56px). v0.1.10 does the same, at 70px, and pass
wrap={false}on the Inline to keep it on one line. At 340px, Select plus Badge plus Button squeezes the badge and button, as it did in v0.1.10.