Skip to content

FilterBar text verb; Combobox keywords, group search and searchPlaceholder - #109

Open
andrewhuhh wants to merge 2 commits into
mainfrom
andrew/search-asks
Open

andrewhuhh wants to merge 2 commits into
mainfrom
andrew/search-asks

Conversation

@andrewhuhh

Copy link
Copy Markdown
Collaborator

Three asks from the license server's gaps audit (INFS-1083: C1, C2 and C4).

  • FilterBar text field verb (C1). A text field can set how its chip reads the value, such as verb: "is" for an exact-match field like an Org ID. The default stays "contains", so existing fields read the same.
  • Combobox keywords and group search (C2). An option's keywords are extra words search matches but never shows, such as Stripe price IDs or a product's other names. Search also matches the option's group heading, so typing "sales" lists the Sales-led group. Server search (onSearch) is unchanged.
  • Combobox searchPlaceholder (C4). This sets the search field's placeholder. The default stays "Search options".

The FilterBar renders were taken with #108 applied, which restores the gap between a chip's field and value. Until #108 merges, chips on main read "Org ID isorg_9f2c41".

Light Dark
Keyword match (a price ID)
Group heading match
No match, long selected label
FilterBar: empty, "Org ID is", long value with "contains" beside it

Open in Capy

…older

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai capy-ai Bot added the live-preview label Nov 17, 2026
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-109-filterbar-text-verb-combobox-keywords-group-search-and-sear

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge.

Summary

Adds custom text for FilterBar chips and expands Combobox search.

  • Text filter chips use the word their field sets.
  • Choice lists find options by hidden terms and group names.
  • Choice search fields can show a caller-provided prompt.
  • The multi-select outside-click check keeps its existing behavior.

Both earlier search gaps are fixed. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Search keywords, group and searchPlaceho..." · Reviewed by Greptile

Comment thread src/ui/combobox.tsx Resolved
Comment thread src/ui/combobox.tsx Resolved
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant