Repository navigation
FilterBar text verb; Combobox keywords, group search and searchPlaceholder - #109
Open
andrewhuhh wants to merge 2 commits into
Open
andrewhuhh wants to merge 2 commits into
andrewhuhh wants to merge 2 commits into
Conversation
…older Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-109-filterbar-text-verb-combobox-keywords-group-search-and-sear Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge.
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three asks from the license server's gaps audit (INFS-1083: C1, C2 and C4).
verb(C1). A text field can set how its chip reads the value, such asverb: "is"for an exact-match field like an Org ID. The default stays "contains", so existing fields read the same.keywordsand group search (C2). An option'skeywordsare extra words search matches but never shows, such as Stripe price IDs or a product's other names. Search also matches the option'sgroupheading, so typing "sales" lists the Sales-led group. Server search (onSearch) is unchanged.searchPlaceholder(C4). This sets the search field's placeholder. The default stays "Search options".The FilterBar renders were taken with #108 applied, which restores the gap between a chip's field and value. Until #108 merges, chips on main read "Org ID isorg_9f2c41".