Repository navigation
Input: add disabledReason - #103
Open
andrewhuhh wants to merge 7 commits into
Open
andrewhuhh wants to merge 7 commits into
andrewhuhh wants to merge 7 commits into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-103-input-add-disabledreason Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
Contributor
|
@greptileai review |
[Medium impact] No new blocking issue was found.
|
Merged
…verrides disabled, and joins aria-describedby Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…orPicker and SecretPathInput honor it Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes INF-183.
Adds
disabledReasonto Input, matching Button, Switch, DropdownMenuItem and Combobox. A field with a reason:readOnlyplusaria-disabled="true", never the nativedisabled)aria-descriptionreadOnly's lock icon and thesuggestedValuehint, so a field never shows two lock affordancesThe field-box flags now treat
aria-disabled="true"as disabled and stop treating it as read only, so boxed inputs (icon, kbd, trailing) get the same look as plain ones. The docs gain a "Disabled with a reason, beside read only" example.Checked in the browser: the field takes focus by Tab, typing leaves the value unchanged, the tooltip appears on focus and on hover, and only plain read only shows the lock.