Skip to content

Update Arabic Translation#71

Closed
my-live-is-a-lie wants to merge 3 commits into
InfinityLoop1308:devfrom
my-live-is-a-lie:patch-1
Closed

Update Arabic Translation#71
my-live-is-a-lie wants to merge 3 commits into
InfinityLoop1308:devfrom
my-live-is-a-lie:patch-1

Conversation

@my-live-is-a-lie

Copy link
Copy Markdown

I added some missing translations for the Arabic translation since it was a bit outdated.

I added some missing translations for Arabic since it was a bit outdated
@my-live-is-a-lie
my-live-is-a-lie marked this pull request as draft July 3, 2026 23:13
Fix and Removed untranslated strings and added all (plurals) in the end of xml file
@my-live-is-a-lie
my-live-is-a-lie marked this pull request as ready for review July 3, 2026 23:25
@InfinityLoop1308

Copy link
Copy Markdown
Owner

Thanks but you are using NewPipe for keys like error_report_notification_title_new, and we are PipePipe.
Please fix.

Fixed some keys having NewPipe string instead of PipePipe.
@my-live-is-a-lie

Copy link
Copy Markdown
Author

Thanks but you are using NewPipe for keys like error_report_notification_title_new, and we are PipePipe. Please fix.

Hi, i fixed it now

I was re-using old translated strings from the previous translator, because i didn't want to re-do the translation again from scratch and he was using (newpipe) string, i planned to change this later to (pipepipe) after i done adding some missing untranslated strings but i totally forgot that.

@my-live-is-a-lie

Copy link
Copy Markdown
Author

Also you may find in the new commit that all strings got changed this is because i downloaded the old strings.xml and edited it with a text editor and i copied my changed text and pasted it in the new commit
I did that because i am using a phone and GitHub in the browser doesn't seem to support the search function so i used an external text editor to make it easy to search and replace the strings.

@InfinityLoop1308

Copy link
Copy Markdown
Owner

Thanks for working on this. The latest strings.xml is currently invalid: the original resource block is closed with </resources>, then another set of strings is appended before a second closing tag. This also duplicates most resource names, so the resulting diff cannot be built or reviewed reliably.

Meanwhile, #79 covers the same scope with a clean and focused diff, making it the better base to continue from. I’m going to proceed with #79 and close this PR to avoid maintaining two competing translations.

Since you have already translated much of the same content, your review of #79 would be valuable. If you find any wording in #79 that should be improved, please leave your suggestions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants