Skip to content

Stale queue #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haizhongzheng merged 3 commits into from
Jul 14, 2026
Merged

Stale queue #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ce9f33
feat(dataflow): earliest-deadline-first rollout buffer consumption
haizhongzheng Jul 14, 2026
a151832
recipes: add qwen3-4b staleness A/B pair (edf vs fifo queue order)
haizhongzheng Jul 14, 2026
d38680a
docs: warn that flash-attn must be installed from outside the repo
haizhongzheng Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions astraflow/core/config/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ def load_dataflow_config(raw: dict) -> dict:
_set_if_missing(agent_fields, "replay_size", buffer.get("replay_size"))
_set_if_missing(agent_fields, "replay_ratio", buffer.get("replay_ratio"))
_set_if_missing(agent_fields, "max_staleness", buffer.get("max_staleness"))
_set_if_missing(agent_fields, "queue_order", buffer.get("queue_order"))
_set_if_missing(agent_fields, "filter_function", buffer.get("filter_function"))

# Extract service-level config from agent_fields (they're in the
Expand Down
2 changes: 2 additions & 0 deletions astraflow/dataflow/astraflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def __init__(
max_staleness: int | None = None,
replay_max_size: int | None = None,
replay_selection_fn: ReplaySelectionFn | str | None = None,
queue_order: str = "edf",
producer_error_backoff: float = 0.5,
data_serving: DataServing | None = None,
data_acquisition: DataAcquisition | None = None,
Expand All @@ -71,6 +72,7 @@ def __init__(
max_staleness=max_staleness,
replay_max_size=replay_max_size,
replay_selection_fn=replay_selection_fn,
queue_order=queue_order,
per_model_config=per_model_buffer_config,
)
self.data_serving = data_serving
Expand Down
6 changes: 5 additions & 1 deletion astraflow/dataflow/data_serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def __init__(
max_staleness: int | None = None,
replay_max_size: int | None = None,
replay_selection_fn: ReplaySelectionFn | str | None = None,
queue_order: str = "edf",
):
resolved_replay_selection_fn = self._resolve_replay_selection_fn(
replay_selection_fn
Expand All @@ -139,6 +140,7 @@ def __init__(
max_staleness=max_staleness,
replay_max_size=replay_max_size,
replay_selection_fn=resolved_replay_selection_fn,
queue_order=queue_order,
)
self._acq_stats_lock = threading.Lock()
self._acq_stats: dict[str, float | int] = _empty_acquisition_stats()
Expand Down Expand Up @@ -392,7 +394,7 @@ class MultiModelDataServing:
per_model_config : dict[str, dict] | None
Optional per-model overrides. Keys are model_ids, values are dicts
with optional keys ``buffer_size``, ``max_staleness``,
``replay_max_size``.
``replay_max_size``, ``queue_order``.
"""

def __init__(
Expand All @@ -405,6 +407,7 @@ def __init__(
max_staleness: int | None = None,
replay_max_size: int | None = None,
replay_selection_fn: ReplaySelectionFn | str | None = None,
queue_order: str = "edf",
per_model_config: dict[str, dict] | None = None,
):
if model_ids is not None and len(model_ids) > 0:
Expand All @@ -424,6 +427,7 @@ def __init__(
max_staleness=cfg.get("max_staleness", max_staleness),
replay_max_size=cfg.get("replay_max_size", replay_max_size),
replay_selection_fn=replay_selection_fn,
queue_order=cfg.get("queue_order", queue_order),
)
buf.buffer.label = f"[{mid}] " if self._is_multi_model else ""
self.buffers[mid] = buf
Expand Down
Loading
Loading