Repository navigation
fix(oid4vc): advertise only ES256 for DPoP - #40
Merged
Merged
Conversation
The authorization server metadata listed ES256, ES384 and ES512 in dpop_signing_alg_values_supported. HAIP requires ES256, and it is the only ECDSA algorithm jwt_verify supports, so ES384 and ES512 had nothing behind them. Wallets that deserialize the list strictly also rejected the whole metadata document on ES512, which blocked issuance to them entirely. Signed-off-by: Eldersonar <slavaecu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
AS metadata advertised
dpop_signing_alg_values_supported: ["ES256", "ES384", "ES512"]. HAIP requiresES256, the only ECDSA algorithmjwt_verifysupports, so ES384/ES512 had nothing behind them. A wallet that parses the list strictly (holdr2.0.2-rc.4) rejected the whole metadata document onES512and couldn't receive credentials.openid_configurationadvertises["ES256"].ES256.Related Issues
Pull Request Checklist
Signed-off-byline (we use the DCO GitHub app to enforce this).scripts/preflightto run tests and check code style).CHANGELOG.mdis up to date and changed in this PR.