Include a fail_level in the check links ci files - #570
Merged
Adrian D'Alessandro (AdrianDAlessandro) merged 1 commit intoAug 24, 2026
Merged
Conversation
Adrian D'Alessandro (AdrianDAlessandro)
requested a review
from Sahil Raja (Sahil590)
August 14, 2026 13:41
Adrian D'Alessandro (AdrianDAlessandro)
requested a review
from Alex Dewar (alexdewar)
as a code owner
August 14, 2026 13:41
Adrian D'Alessandro (AdrianDAlessandro)
requested review from
Christopher Cave-Ayland (cc-a) and
Diego Alonso Álvarez (dalonsoa)
as code owners
August 14, 2026 13:41
Copilot started reviewing on behalf of
Adrian D'Alessandro (AdrianDAlessandro)
August 14, 2026 13:42
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linkspector GitHub Actions workflows to ensure link checking fails the CI job when broken links are detected by setting the fail_level input.
Changes:
- Add
fail_level: anyto Linkspector steps in the repository workflow. - Add
fail_level: anyto Linkspector steps in the cookiecutter template workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/check-links.yml |
Adds fail_level to Linkspector action configuration so broken links fail CI. |
{{ cookiecutter.project_slug }}/.github/workflows/check-links.yml |
Mirrors the same fail_level behaviour in the generated project template workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Diego Alonso Álvarez (dalonsoa)
approved these changes
Aug 18, 2026
Diego Alonso Álvarez (dalonsoa)
left a comment
Contributor
There was a problem hiding this comment.
OK. Weird that the default behaviour of a tool that check links is not failing when it finds links that are not working.
Adrian D'Alessandro (AdrianDAlessandro)
merged commit Aug 24, 2026
e089f4a
into
main
7 checks passed
Adrian D'Alessandro (AdrianDAlessandro)
deleted the
check-links-fail-level
branch
August 24, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It appears that the Linkspector action will not fail on bad links unless a
fail_levelis set as a parameter (see this PR in DIRECT web app). This PR adds it to both workflows in this repo.Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))