Skip to content

Include a fail_level in the check links ci files - #570

Merged
Adrian D'Alessandro (AdrianDAlessandro) merged 1 commit into
mainfrom
check-links-fail-level
Aug 24, 2026
Merged

Adrian D'Alessandro (AdrianDAlessandro) merged 1 commit into
mainfrom
check-links-fail-level

Conversation

@AdrianDAlessandro

Copy link
Copy Markdown
Contributor

Description

It appears that the Linkspector action will not fail on bad links unless a fail_level is set as a parameter (see this PR in DIRECT web app). This PR adds it to both workflows in this repo.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Linkspector GitHub Actions workflows to ensure link checking fails the CI job when broken links are detected by setting the fail_level input.

Changes:

  • Add fail_level: any to Linkspector steps in the repository workflow.
  • Add fail_level: any to Linkspector steps in the cookiecutter template workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/check-links.yml Adds fail_level to Linkspector action configuration so broken links fail CI.
{{ cookiecutter.project_slug }}/.github/workflows/check-links.yml Mirrors the same fail_level behaviour in the generated project template workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/check-links.yml
Comment thread {{ cookiecutter.project_slug }}/.github/workflows/check-links.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Weird that the default behaviour of a tool that check links is not failing when it finds links that are not working.

@AdrianDAlessandro
Adrian D'Alessandro (AdrianDAlessandro) merged commit e089f4a into main Aug 24, 2026
7 checks passed
@AdrianDAlessandro
Adrian D'Alessandro (AdrianDAlessandro) deleted the check-links-fail-level branch August 24, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants