Skip to content

Build all demos as C89 - #42

Merged
RobLoach merged 1 commit into
Immediate-Mode-UI:masterfrom
ccawley2011:c89
Dec 15, 2021
Merged

Build all demos as C89#42
RobLoach merged 1 commit into
Immediate-Mode-UI:masterfrom
ccawley2011:c89

Conversation

@ccawley2011

Copy link
Copy Markdown
Contributor

This was originally submitted as vurtun/nuklear#814. It also supercedes PR #39.

@Hejsil Hejsil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have a minor comment

Comment thread demo/allegro5/nuklear_allegro5.h
@RobLoach

Copy link
Copy Markdown
Contributor

Looks like there are conflicts popping up.

@dumblob

dumblob commented Dec 14, 2021

Copy link
Copy Markdown
Member

We're sorry for the delay which apparently causes merge conflicts. Would you or anyone else be willing to fix the conflicts? We'll then do final skim through it and merge it. Thanks!

@ccawley2011

Copy link
Copy Markdown
Contributor Author

We're sorry for the delay which apparently causes merge conflicts. Would you or anyone else be willing to fix the conflicts? We'll then do final skim through it and merge it. Thanks!

OK, done.

@RobLoach RobLoach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to build all allegro, glfw, sdl, sfml, wayland, and x11 demos. Did find the following warnings when building x11_rawfb for nuklear_rafb.h, and the unused functions, but other than that, this looks good...

In file included from main.c:50:
nuklear_rawfb.h: In function ‘nk_rawfb_img_setpixel’:
nuklear_rawfb.h:182:27: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
  182 |         ptr = img->pixels + (img->pitch * y0);
      |                           ^
nuklear_rawfb.h: In function ‘nk_rawfb_img_getpixel’:
nuklear_rawfb.h:201:27: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
  201 |         ptr = img->pixels + (img->pitch * y0);
      |                           ^
In file included from main.c:49:
At top level:
../../nuklear.h:6166:1: warning: ‘nk_cos’ defined but not used [-Wunused-function]
 6166 | nk_cos(float x)
      | ^~~~~~
../../nuklear.h:6150:1: warning: ‘nk_sin’ defined but not used [-Wunused-function]
 6150 | nk_sin(float x)
      | ^~~~~~
../../nuklear.h:6136:1: warning: ‘nk_inv_sqrt’ defined but not used [-Wunused-function]
 6136 | nk_inv_sqrt(float n)
      | ^~~~~~~~~~~

@RobLoach
RobLoach merged commit 85c88b6 into Immediate-Mode-UI:master Dec 15, 2021
@ccawley2011
ccawley2011 deleted the c89 branch December 15, 2021 01:52
@dumblob

dumblob commented Dec 15, 2021

Copy link
Copy Markdown
Member

Thanks everyone! Especially @ccawley2011 for years-long patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants