Validate collection sharing constraints in the API view#1497
Open
brianhelba wants to merge 1 commit into
Open
Conversation
brianhelba
force-pushed
the
enforce-grantor-grantee-constraint
branch
from
307fcc9 to
62d2a53
Compare
Add checks to reject sharing a collection with yourself or sharing a magic collection, before the Celery task is dispatched. Previously, the self-share case would awkwardly fail in the task when it hit the `collectionshare_grantor_grantee_diff_check` database constraint.
brianhelba
force-pushed
the
enforce-grantor-grantee-constraint
branch
from
62d2a53 to
33dae18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks to reject sharing a collection with yourself or sharing a magic collection, before the Celery task is dispatched. Previously, the self-share case would awkwardly fail in the task when it hit the
collectionshare_grantor_grantee_diff_checkdatabase constraint.