Skip to content

Fix the launch crash on Android under NativePHP v4 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ikromjon1998 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the launch crash on Android under NativePHP v4 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.5.0-beta.2] - 2026-10-04

> **Pre-release.** Replaces 1.5.0-beta.1, which crashes at launch on Android under NativePHP
> Mobile v4. Scanning itself still has not been run on a physical device. Install with
> `composer require ikromjon/nativephp-mobile-document-scanner:^1.5@beta`.

### Fixed

- Android: the app crashed at launch on NativePHP for Mobile v4. v4 creates bridge functions
after the activity has resumed, and the scanner registered its result launcher with
`registerForActivityResult()`, which Android only allows before the activity starts. The
launcher is now registered with the activity's result registry directly, which is valid at
any point. NativePHP v3 creates bridge functions in `onCreate` and was not affected

## [1.5.0-beta.1] - 2026-10-03

> **Pre-release.** The native fixes below compile in a NativePHP Mobile v4 app on iOS and
Expand Down
16 changes: 14 additions & 2 deletions resources/android/src/DocumentScannerFunctions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ import org.json.JSONArray
import org.json.JSONObject
import java.io.File
import java.io.FileOutputStream
import java.lang.ref.WeakReference

object DocumentScannerFunctions {
private const val TAG = "DocumentScanner"
private const val SCAN_LAUNCHER_KEY = "com.nativephp.documentscanner.scan"

private var defaultMaxPages = 0
private var defaultOutputFormat = "jpeg"
Expand All @@ -36,6 +38,7 @@ object DocumentScannerFunctions {
private var defaultScannerMode = "full"

private var scannerLauncher: ActivityResultLauncher<IntentSenderRequest>? = null
private var launcherOwner: WeakReference<FragmentActivity>? = null
private var currentOutputFormat = "jpeg"
private var currentJpegQuality = 90

Expand Down Expand Up @@ -67,11 +70,20 @@ object DocumentScannerFunctions {
}
}

/**
* Registers with the activity's result registry directly rather than
* through registerForActivityResult(). That call is only legal before the
* activity is STARTED, and NativePHP v4 creates bridge functions after the
* activity has resumed, so it crashed the app at launch.
*/
fun registerLauncher(activity: FragmentActivity) {
if (scannerLauncher != null) return
if (scannerLauncher != null && launcherOwner?.get() === activity) return

scannerLauncher?.unregister()
launcherOwner = WeakReference(activity)
scannerLauncher =
activity.registerForActivityResult(
activity.activityResultRegistry.register(
SCAN_LAUNCHER_KEY,
ActivityResultContracts.StartIntentSenderForResult(),
) { result: ActivityResult ->
if (result.resultCode == Activity.RESULT_OK) {
Expand Down
Loading