Skip to content

Align isolated loader with Pi SDK #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IgorWarzocha merged 1 commit into from
Jun 18, 2026
Merged

Align isolated loader with Pi SDK #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions desktop/runtime/isolated-settings-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import path from 'node:path'
import type { ResourceLoader, SettingsManager } from '@earendil-works/pi-coding-agent'
import type { SettingsManager } from '@earendil-works/pi-coding-agent'
import type { PiDefaultProjectTrust } from '../../shared/desktop-settings-contracts.ts'

type SettingsManagerFactory = {
Expand All @@ -11,6 +11,9 @@ type SettingsManagerFactory = {
inMemory: (settings?: Record<string, unknown>) => SettingsManager
}

type DefaultResourceLoaderFactory =
typeof import('@earendil-works/pi-coding-agent').DefaultResourceLoader

export function getRuntimeDefaultProjectTrust(options: {
SettingsManager: SettingsManagerFactory
agentDir: string
Expand Down Expand Up @@ -106,14 +109,7 @@ export function createRuntimeSettingsManager(options: {
}

export async function createIsolatedRuntimeResourceLoader(options: {
DefaultResourceLoader: new (loaderOptions: {
cwd: string
agentDir: string
settingsManager: SettingsManager
noSkills?: boolean
additionalSkillPaths?: string[]
systemPrompt?: string
}) => ResourceLoader
DefaultResourceLoader: DefaultResourceLoaderFactory
cwd: string
agentDir: string
settingsCwd?: string | null | undefined
Expand Down