refactor: grid internals and controllers - #80
Merged
Conversation
Reduce duplication and indirection across /src with no behavior or public API changes: - Factor the shared emit -> commit -> emit flow in FilterController into a single helper. - Collapse the six navigation handlers into two clamped movement primitives. - Extract the slotted-column scan in the grid, shared by slot change and column detection. - Add resolveCondition() to replace the repeated operand lookup casts in grid, filter controller and filter row. - Unify the active/inactive chip rendering in the filter row. - Drop needless indirection: pipeline getters, tree iterator generator, sort direction Map, first-render branch in partMap. - Flatten nested ternaries in header sort rendering and the filter row state preview; extract a shared adopt-styles predicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce duplication and indirection across /src with no behavior or public API changes: