Skip to content

feat(*): adding themePicker to Samples - #524

Open
ChronosSF wants to merge 2 commits into
vnextfrom
sstoychev/add-theming-widget
Open

feat(*): adding themePicker to Samples#524
ChronosSF wants to merge 2 commits into
vnextfrom
sstoychev/add-theming-widget

Conversation

@ChronosSF

Copy link
Copy Markdown
Member
  • Updates astro-components to 1.1.0 for theme picker
  • Adds theme picker to all non-theming samples

@ChronosSF
ChronosSF requested a review from DiLazarova August 27, 2026 07:05
@ChronosSF

Copy link
Copy Markdown
Member Author

@DiLazarova , one thing that I think we didn't test properly is that if the the "open sample" button is to the right, then the theme picker looks a bit weird between two buttons of different roundness and size:

image

Maybe we need to style the dropdown to better match the other controls on the bottom.

Please, also check how the samples behave in dark mode, I think we have to modify some styles so they look better in dark mode.

@DiLazarova

Copy link
Copy Markdown
Contributor

@ChronosSF
The footer of the frame looks like this by design:

Screenshot 2026-08-27 at 14 03 21

Sure, I will test the dark mode too!

@DiLazarova

DiLazarova commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Test and Review in Angular and React

All the examples should be in dark mode. All components inside should be in dark mode too.

Screenshot 2026-08-27 at 14 52 39

Should look like this in dark mode
Screenshot 2026-08-27 at 14 53 56

This is also relevant for Avatar component.

Here are the examples of Badge in Dark Mode: Figma Design

@DiLazarova

Copy link
Copy Markdown
Contributor

Double check for React

All the components should be in dark mode
Screenshot 2026-08-27 at 15 14 42

The descriptive text should be gray 200
Screenshot 2026-08-27 at 15 15 36

There are some dark gray background around all the samples.
Screenshot 2026-08-27 at 15 17 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants