feat(*): adding themePicker to Samples - #524
Open
ChronosSF wants to merge 2 commits into
Open
Conversation
ChronosSF
commented
Aug 27, 2026
Member
- Updates astro-components to 1.1.0 for theme picker
- Adds theme picker to all non-theming samples
Member
Author
|
@DiLazarova , one thing that I think we didn't test properly is that if the the "open sample" button is to the right, then the theme picker looks a bit weird between two buttons of different roundness and size:
Maybe we need to style the dropdown to better match the other controls on the bottom. Please, also check how the samples behave in dark mode, I think we have to modify some styles so they look better in dark mode. |
Contributor
|
@ChronosSF
Sure, I will test the dark mode too! |
Contributor
Test and Review in Angular and ReactAll the examples should be in dark mode. All components inside should be in dark mode too.
Should look like this in dark mode This is also relevant for Avatar component. Here are the examples of Badge in Dark Mode: Figma Design |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






