Skip to content

fix: keep saved READY strategies launchable - #177

Merged
pjy008008 merged 1 commit into
developfrom
fix/strategy-launch-gate
Aug 9, 2026
Merged

fix: keep saved READY strategies launchable#177
pjy008008 merged 1 commit into
developfrom
fix/strategy-launch-gate

Conversation

@pjy008008

Copy link
Copy Markdown
Contributor

What changed

  • derive personal-bot launch eligibility from the saved READY validation that matches the current editor signature
  • keep automatic validation previews advisory for an unchanged saved revision
  • show preview/catalog differences without disabling launch
  • extend the real authoring interaction test to cover READY load, invalid preview, edit invalidation, save, validation, and release

Why

The editor briefly restored the saved VALID result, then replaced the launch gate with an automatic preview result about 300 ms later. A preview mismatch therefore disabled a strategy that the library and release API correctly considered launchable.

Impact

An unchanged saved READY strategy remains launchable. Any actual edit still changes the editor signature and disables launch until that revision is saved and validated again.

Checks

  • pnpm exec vitest run src/StrategyApiView.test.tsx (15/15)
  • pnpm typecheck
  • pnpm build
  • node scripts/assert-production-bundle.mjs
  • pnpm exec vitest run src/CompetitionApiWorkspace.test.tsx (9/9, isolated follow-up)

The Windows full-suite parallel run exposed intermittent failures in unrelated landing/competition tests; the touched regression suite and the isolated failed suite pass. GitHub CI will run the full Linux matrix.

@pjy008008
pjy008008 merged commit 4a4e147 into develop Aug 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant