fix: keep saved READY strategies launchable - #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The editor briefly restored the saved VALID result, then replaced the launch gate with an automatic preview result about 300 ms later. A preview mismatch therefore disabled a strategy that the library and release API correctly considered launchable.
Impact
An unchanged saved READY strategy remains launchable. Any actual edit still changes the editor signature and disables launch until that revision is saved and validated again.
Checks
pnpm exec vitest run src/StrategyApiView.test.tsx(15/15)pnpm typecheckpnpm buildnode scripts/assert-production-bundle.mjspnpm exec vitest run src/CompetitionApiWorkspace.test.tsx(9/9, isolated follow-up)The Windows full-suite parallel run exposed intermittent failures in unrelated landing/competition tests; the touched regression suite and the isolated failed suite pass. GitHub CI will run the full Linux matrix.