Skip to content

Transmit an absolute object url - #1173

Merged
yhabteab merged 2 commits into
mainfrom
transmit-absolute-object-url
Sep 2, 2026
Merged

Transmit an absolute object url#1173
yhabteab merged 2 commits into
mainfrom
transmit-absolute-object-url

Conversation

@DsgnrFH

@DsgnrFH DsgnrFH commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes #1172

@DsgnrFH
DsgnrFH requested review from oxzi and yhabteab September 1, 2026 07:56
@DsgnrFH DsgnrFH self-assigned this Sep 1, 2026
@DsgnrFH DsgnrFH added the go Pull requests that update Go code label Sep 1, 2026
@cla-bot cla-bot Bot added the cla/signed label Sep 1, 2026
@DsgnrFH
DsgnrFH force-pushed the transmit-absolute-object-url branch from 9b7e2cf to 455c5d5 Compare September 1, 2026 08:21
@yhabteab

yhabteab commented Sep 1, 2026

Copy link
Copy Markdown
Member

Please fix the CI failures.

@DsgnrFH
DsgnrFH force-pushed the transmit-absolute-object-url branch from 455c5d5 to 4ffdf7e Compare September 1, 2026 08:35
@yhabteab
yhabteab removed the request for review from oxzi September 1, 2026 08:59
Comment thread pkg/notifications/config.go Outdated
@DsgnrFH
DsgnrFH force-pushed the transmit-absolute-object-url branch 2 times, most recently from 03c38a5 to 87c3bbe Compare September 1, 2026 13:05
@DsgnrFH
DsgnrFH force-pushed the transmit-absolute-object-url branch from 87c3bbe to 20eeb4f Compare September 2, 2026 08:13
@DsgnrFH

DsgnrFH commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Bumped the icinga-go-library version after the merge

@yhabteab yhabteab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also re-bump the IGL version.

Comment thread internal/config/config_test.go
Comment thread doc/03-Configuration.md
Comment thread pkg/notifications/notifications.go Outdated
@yhabteab yhabteab added this to the 1.6.0 milestone Sep 2, 2026
@DsgnrFH
DsgnrFH requested a review from yhabteab September 2, 2026 09:13

@yhabteab yhabteab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM.

Host:
Image

Service:
Image

@yhabteab
yhabteab merged commit eaab959 into main Sep 2, 2026
31 checks passed
@yhabteab
yhabteab deleted the transmit-absolute-object-url branch September 2, 2026 09:57
@yhabteab

yhabteab commented Sep 2, 2026

Copy link
Copy Markdown
Member

Oh man ey, why 😭. Now, I've also merged a dummy commit without squashing it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transmit an absolute object URL with each event to Icinga Notifications

2 participants