Skip to content

Fix: Network include filter being broken and never being applied properly #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordHepipud wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −10
Open

Fix: Network include filter being broken and never being applied properly #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/31-Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ documentation before upgrading to a new release.

Released closed milestones can be found on [GitHub](https://github.com/Icinga/icinga-powershell-plugins/milestones?state=closed).

## 1.15.0 (2026-06-30)

[Issue and PRs](https://github.com/Icinga/icinga-powershell-plugins/milestone/24)

### Bugfixes

* [#479](https://github.com/Icinga/icinga-powershell-plugins/pull/479) Fixes Network include filter for `Invoke-IcingaCheckNetworkInterface` being broken and never being applied properly

## 1.14.1 (2026-03-31)

[Issue and PRs](https://github.com/Icinga/icinga-powershell-plugins/milestone/23)
Expand Down
12 changes: 2 additions & 10 deletions provider/network/Join-icingaNetworkDeviceDataPerfCounter.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,11 @@ function Join-IcingaNetworkDeviceDataPerfCounter()
continue;
}

if ((Test-IcingaArrayFilter -InputObject $GetNetworkDevice[$DeviceName].DeviceId -Include $IncludeNetworkDevice -Exclude $ExcludeNetworkDevice) -eq $FALSE) {
continue;
}

if ((Test-IcingaArrayFilter -InputObject $DeviceName -Include $IncludeNetworkDevice -Exclude $ExcludeNetworkDevice) -eq $FALSE) {
continue;
}

if ((Test-IcingaArrayFilter -InputObject $GetNetworkDevice[$DeviceName].Name -Include $IncludeNetworkDevice -Exclude $ExcludeNetworkDevice) -eq $FALSE) {
continue;
}

if (($GetNetworkDevice.Containskey($DeviceName)) -eq $fALSE) {
if (($GetNetworkDevice.ContainsKey($DeviceName)) -eq $fALSE) {
continue;
}

Expand All @@ -51,7 +43,7 @@ function Join-IcingaNetworkDeviceDataPerfCounter()
foreach ($key in $NetworkDeviceObject.Keys) {
$CounterObject = $NetworkDeviceObject[$key];
if (($CounterHashObject.ContainsKey($key)) -eq $TRUE) {
$CounterHashObject[$key].value += $CounterObject.value;
$CounterHashObject[$key].value += $CounterObject.value;
} else {
$CounterHashObject.Add($key, $CounterObject);
}
Expand Down