Skip to content

Add list and detail view for sent notifications - #512

Open
sukhwinder33445 wants to merge 4 commits into
mainfrom
add-list-and-detail-view-of-sent-notifications
Open

Add list and detail view for sent notifications#512
sukhwinder33445 wants to merge 4 commits into
mainfrom
add-list-and-detail-view-of-sent-notifications

Conversation

@sukhwinder33445

@sukhwinder33445 sukhwinder33445 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This PR implements the Notification History list and per-notification detail view.

Changes:

  • Added NotificationHistory model + renderer + detail widget, with new controllers for list/detail views.
  • Extended incident detail with a Notification History tab and scoped search suggestions.
  • Added supporting enums, condition description helper, styling, and PHPUnit tests.

resolves #475

require:

@sukhwinder33445 sukhwinder33445 self-assigned this Jul 15, 2026
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Jul 15, 2026
@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 6 times, most recently from cb46a62 to 7c7a8e7 Compare July 21, 2026 12:23
@sukhwinder33445
sukhwinder33445 requested a review from Copilot July 21, 2026 12:24

This comment was marked as resolved.

@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 0d12e38 to 5b985d7 Compare July 21, 2026 14:06
@sukhwinder33445

Copy link
Copy Markdown
Contributor Author

Failing tests will pass once #518 has been merged.

@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 2e42a41 to cc3f767 Compare July 21, 2026 14:57
@sukhwinder33445
sukhwinder33445 requested a review from Copilot July 21, 2026 15:00

This comment was marked as resolved.

@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 7 times, most recently from b10faf4 to d0f39a3 Compare July 27, 2026 14:35
@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 4 times, most recently from cd01600 to 49d332a Compare July 30, 2026 14:29
@sukhwinder33445

Copy link
Copy Markdown
Contributor Author

This is how the list and detail view currently looks like:

Screenshot 2026-07-30 at 16 51 00

@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch 4 times, most recently from 6a03e71 to f547941 Compare August 11, 2026 13:57
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch from f547941 to 897a7ec Compare August 18, 2026 11:38
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 3b4b6ee to db3497f Compare September 2, 2026 09:30
@BastianLedererIcinga
BastianLedererIcinga changed the base branch from main to multiple-related-sources September 2, 2026 09:30
@BastianLedererIcinga

Copy link
Copy Markdown
Contributor

This is how the list and detail view currently looks like:

Screenshot 2026-07-30 at 16 51 00

I will move all trigger chain related code into a draft PR because the daemon does not fully support it yet and the linked issue never mentioned it in the first place.

Base automatically changed from multiple-related-sources to main September 2, 2026 11:11
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 481e77c to 4bd6244 Compare September 3, 2026 07:27
sukhwinder33445 and others added 4 commits September 3, 2026 09:28
This class helps to describe the escalation condition in an easily
readable sentence.
Co-Authored-By: Bastian Lederer <bastian.lederer@icinga.com>
`ObjectSuggestions`: Apply base filter to suggest only
current-incident-based suggestions.

Co-Authored-By: Bastian Lederer <bastian.lederer@icinga.com>
Replaces the string comparisons in `IncidentHistoryRenderer` with the new
`IncidentHistoryType` enum and describes unnamed escalations by their
condition.

Co-Authored-By: Sukhwinder Dhillon <sukhwinder.dhillon@icinga.com>
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch from 4bd6244 to a3c57a3 Compare September 3, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a view for sent notifications

3 participants